Code Review - Time#strftime ignore invalid directives on format string

Ruby IronRuby
1

i asked a pull request ( Time#strftime - any text not listed as a directive in the given format st by enricosada · Pull Request #28 · IronLanguages/main · GitHub
) for fix Time#strftime behaviour on invalid directives on format
string, ex:

ruby 1.8:
Time.now.strftime ‘%$’ => ‘$’
ruby 1.9:
Time.now.strftime ‘%$’ => ‘%$’

this make green a mspec test on core/time/strftime_spec.rb

I have some question:

  1. i added a check for ruby compatibility >= ruby 1.9, is needed?
  2. i removed ‘fails:’ from
    ironruby-tags-19/core/time/strftime_tags.txt is correct?
  3. usually code review is in mailing list or github pull request? (so
    i dont need to write two times the same questions)
2

You can remove compatibility check (including the one that’s there).
IronRuby only supports MRI 1.9.

Tomas

3

On Tue, Aug 2, 2011 at 12:44 PM, Enrico S. [email protected]
wrote:

Looks good. Did the test fail before ths change?

I have some question:

  1. i added a check for ruby compatibility >= ruby 1.9, is needed?

Not really as we have explicitly decided that IronRuby 1.x targets MRI
1.9,
and doesn’t support 1.8.x anymore. However, we didn’t remove any of
those
checks for 1.8. It doesn’t hurt, but isn’t required.

  1. i removed ‘fails:’ from
    ironruby-tags-19/core/time/strftime_tags.txt is correct?

Yup, you fixed that test so no need for the guard anymore.

  1. usually code review is in mailing list or github pull request? (so
    i dont need to write two times the same questions)

It doesn’t matter where you actually write the text, but the pull
request is
needed as well as notifying the mailing list. I say put everything in
the
pull request, and then send the link to the pull request to the mailing
list.

4

updated removing checks, now is ready to pull

5

yes the test was red before.

i will remove the checks for 1.9 (are useless) and update the pull
request.