Code Review: Spec changes

tfpt review “/shelveset:rubyspec2;jdeville”

  •     Changed all invocations of mspec to use the mspec command with 
    

Ruby instead of the mspec-ci or mspec-run command with IronRuby. This
will allow us to take advantage of future options added to the mspec
runner, and possibly add parallel process support if it gets added to
mspec.

  •     Changed the custom runners for baseline and tag to mspec ci 
    

and mspec tag. No reason to invent the wheel, and this is how SNAP will
be running. This has the side effect of changing the tags to fails from
fail

  •     Added the -G critical option to all runners. Critical tags 
    

will be used to mark IronRuby bugs that block the runner. This is based
on a discussion on #rubyspec about how other implementations are
tracking bugs. The tag file is how things should be excluded unless they
are bugs with the reference implementation (CRuby). Thus instead of the
ironruby_bug guard, I have moved to a critical tag, which can be
regenerated from this file.

  •     Added a method to generate the tags from an existing 
    

critical_tags.txt file. Currently this file is the output of
Powershell’s Get-Child-Items -r -i *.txt | select-string critical, with
some modification to remove new lines. Suggestions for options for
automatically generating this file are welcome.

  •     Added a rake task (regen_tags) to generate the critical tags.
    

Github commits:
IronRuby-tags:
90e33e19

Added a critical tags file to regenerate tags from.

c5f6359

Rebaselined the specs.

Mspec:
18db1cf

              Added critical tag to mspec ci
              Reordered tmp helper to respect  ENV variables before 

attempting to guess.

Rubyspec:
1e57876

              Removed ironruby_bug guards due to the change to 

critical tags.

Reviewed F2F with John.

JD

From: [email protected]
[mailto:[email protected]] On Behalf Of Jim D.
Sent: Monday, July 14, 2008 10:22 PM
To: [email protected]; IronRuby External Code R.;
Srivatsn Narayanan
Subject: [Ironruby-core] Code Review: Spec changes

tfpt review “/shelveset:rubyspec2;jdeville”

  •     Changed all invocations of mspec to use the mspec command with 
    

Ruby instead of the mspec-ci or mspec-run command with IronRuby. This
will allow us to take advantage of future options added to the mspec
runner, and possibly add parallel process support if it gets added to
mspec.

  •     Changed the custom runners for baseline and tag to mspec ci 
    

and mspec tag. No reason to invent the wheel, and this is how SNAP will
be running. This has the side effect of changing the tags to fails from
fail

  •     Added the -G critical option to all runners. Critical tags 
    

will be used to mark IronRuby bugs that block the runner. This is based
on a discussion on #rubyspec about how other implementations are
tracking bugs. The tag file is how things should be excluded unless they
are bugs with the reference implementation (CRuby). Thus instead of the
ironruby_bug guard, I have moved to a critical tag, which can be
regenerated from this file.

  •     Added a method to generate the tags from an existing 
    

critical_tags.txt file. Currently this file is the output of
Powershell’s Get-Child-Items -r -i *.txt | select-string critical, with
some modification to remove new lines. Suggestions for options for
automatically generating this file are welcome.

  •     Added a rake task (regen_tags) to generate the critical tags.
    

Github commits:
IronRuby-tags:
90e33e19

Added a critical tags file to regenerate tags from.

c5f6359

Rebaselined the specs.

Mspec:
18db1cf

              Added critical tag to mspec ci
              Reordered tmp helper to respect  ENV variables before 

attempting to guess.

Rubyspec:
1e57876

              Removed ironruby_bug guards due to the change to 

critical tags.

Can you send links to github instead of just the commit sha1?


From: [email protected]
[[email protected]] On Behalf Of Jim D.
[[email protected]]
Sent: Tuesday, July 15, 2008 2:31 PM
To: [email protected]; IronRuby External Code R.;
Srivatsn Narayanan
Subject: Re: [Ironruby-core] Code Review: Spec changes

Reviewed F2F with John.

JD

From: [email protected]
[mailto:[email protected]] On Behalf Of Jim D.
Sent: Monday, July 14, 2008 10:22 PM
To: [email protected]; IronRuby External Code R.;
Srivatsn Narayanan
Subject: [Ironruby-core] Code Review: Spec changes

tfpt review “/shelveset:rubyspec2;jdeville”

• Changed all invocations of mspec to use the mspec command with
Ruby instead of the mspec-ci or mspec-run command with IronRuby. This
will allow us to take advantage of future options added to the mspec
runner, and possibly add parallel process support if it gets added to
mspec.

• Changed the custom runners for baseline and tag to mspec ci
and mspec tag. No reason to invent the wheel, and this is how SNAP will
be running. This has the side effect of changing the tags to fails from
fail

• Added the -G critical option to all runners. Critical tags
will be used to mark IronRuby bugs that block the runner. This is based
on a discussion on #rubyspec about how other implementations are
tracking bugs. The tag file is how things should be excluded unless they
are bugs with the reference implementation (CRuby). Thus instead of the
ironruby_bug guard, I have moved to a critical tag, which can be
regenerated from this file.

• Added a method to generate the tags from an existing
critical_tags.txt file. Currently this file is the output of
Powershell’s Get-Child-Items -r -i *.txt | select-string critical, with
some modification to remove new lines. Suggestions for options for
automatically generating this file are welcome.

• Added a rake task (regen_tags) to generate the critical tags.

Github commits:
IronRuby-tags:
90e33e19

Added a critical tags file to regenerate tags from.

c5f6359

Rebaselined the specs.

Mspec:
18db1cf

              Added critical tag to mspec ci
              Reordered tmp helper to respect  ENV variables before 

attempting to guess.

Rubyspec:
1e57876

              Removed ironruby_bug guards due to the change to 

critical tags.

I remembered that shortly after I sent this mail last night. One of
these times I will get it.

JD

From: [email protected]
[mailto:[email protected]] On Behalf Of Jimmy
Schementi
Sent: Tuesday, July 15, 2008 2:49 PM
To: [email protected]; IronRuby External Code R.;
Srivatsn Narayanan
Subject: Re: [Ironruby-core] Code Review: Spec changes

Can you send links to github instead of just the commit sha1?


From: [email protected]
[[email protected]] On Behalf Of Jim D.
[[email protected]]
Sent: Tuesday, July 15, 2008 2:31 PM
To: [email protected]; IronRuby External Code R.;
Srivatsn Narayanan
Subject: Re: [Ironruby-core] Code Review: Spec changes
Reviewed F2F with John.

JD

From: [email protected]
[mailto:[email protected]] On Behalf Of Jim D.
Sent: Monday, July 14, 2008 10:22 PM
To: [email protected]; IronRuby External Code R.;
Srivatsn Narayanan
Subject: [Ironruby-core] Code Review: Spec changes

tfpt review “/shelveset:rubyspec2;jdeville”

  •     Changed all invocations of mspec to use the mspec command with 
    

Ruby instead of the mspec-ci or mspec-run command with IronRuby. This
will allow us to take advantage of future options added to the mspec
runner, and possibly add parallel process support if it gets added to
mspec.

  •     Changed the custom runners for baseline and tag to mspec ci 
    

and mspec tag. No reason to invent the wheel, and this is how SNAP will
be running. This has the side effect of changing the tags to fails from
fail

  •     Added the -G critical option to all runners. Critical tags 
    

will be used to mark IronRuby bugs that block the runner. This is based
on a discussion on #rubyspec about how other implementations are
tracking bugs. The tag file is how things should be excluded unless they
are bugs with the reference implementation (CRuby). Thus instead of the
ironruby_bug guard, I have moved to a critical tag, which can be
regenerated from this file.

  •     Added a method to generate the tags from an existing 
    

critical_tags.txt file. Currently this file is the output of
Powershell’s Get-Child-Items -r -i *.txt | select-string critical, with
some modification to remove new lines. Suggestions for options for
automatically generating this file are welcome.

  •     Added a rake task (regen_tags) to generate the critical tags.
    

Github commits:
IronRuby-tags:
90e33e19

Added a critical tags file to regenerate tags from.

c5f6359

Rebaselined the specs.

Mspec:
18db1cf

              Added critical tag to mspec ci
              Reordered tmp helper to respect  ENV variables before 

attempting to guess.

Rubyspec:
1e57876

              Removed ironruby_bug guards due to the change to 

critical tags.

This forum is not affiliated to the Ruby language, Ruby on Rails framework, nor any Ruby applications discussed here.

| Privacy Policy | Terms of Service | Remote Ruby Jobs