Code Review: ShellExec7

tfpt review “/shelveset:ShellExec7;REDMOND\tomat”
Comment :
Fixes issues with Kernel#, system and exec. Paths with spaces and shell commands were not handled correctly. Also fixes a bug in mspec/lib/mspec/helpers/ruby_exe.rb - it didn't handle spaces in RUBY_EXE path correctly. Implements Win32API library - irb depends on it if run on Windows and it "worked" only due to a bug in Kernel#.
Fixes IO#tty? - it only returns true if the console stream is not
redirected to a file or a pipe. Adds some specs to test this.
Disables Process::UID and Process::Sys specs on Windows.

Tomas

This forum is not affiliated to the Ruby language, Ruby on Rails framework, nor any Ruby applications discussed here.

| Privacy Policy | Terms of Service | Remote Ruby Jobs