tfpt review “/shelveset:rakecrossplatform;REDMOND\jdeville”
Comment :
Fixes the imports to reference the files in a platform agnostic way.
Looks good!
I’m going to directly commit this since it doesn’t affect tests.
JD
By the by, forward slashes are acceptable as path separators in windows
as
well as under unix. This /may/ be more acceptable as it’s clearer,
IMHO.
Committing with Michael’s suggestion.
JD
From: [email protected]
[mailto:[email protected]] On Behalf Of Michael
Letterle
Sent: Wednesday, December 31, 2008 8:23 PM
To: [email protected]
Subject: Re: [Ironruby-core] Code Review: rakecrossplatform
By the by, forward slashes are acceptable as path separators in windows
as well as under unix. This /may/ be more acceptable as it’s clearer,
IMHO.
On Wed, Dec 31, 2008 at 4:29 PM, Jim D.
<[email protected]mailto:[email protected]> wrote:
I’m going to directly commit this since it doesn’t affect tests.
JD