Code Review: rakecrossplatform


#1

tfpt review “/shelveset:rakecrossplatform;REDMOND\jdeville”
Comment :
Fixes the imports to reference the files in a platform agnostic way.


#2

Looks good!


#3

I’m going to directly commit this since it doesn’t affect tests.

JD


#4

By the by, forward slashes are acceptable as path separators in windows
as
well as under unix. This /may/ be more acceptable as it’s clearer,
IMHO.


#5

Committing with Michael’s suggestion.

JD

From: removed_email_address@domain.invalid
[mailto:removed_email_address@domain.invalid] On Behalf Of Michael
Letterle
Sent: Wednesday, December 31, 2008 8:23 PM
To: removed_email_address@domain.invalid
Subject: Re: [Ironruby-core] Code Review: rakecrossplatform

By the by, forward slashes are acceptable as path separators in windows
as well as under unix. This /may/ be more acceptable as it’s clearer,
IMHO.
On Wed, Dec 31, 2008 at 4:29 PM, Jim D.
<removed_email_address@domain.invalidmailto:removed_email_address@domain.invalid> wrote:
I’m going to directly commit this since it doesn’t affect tests.

JD