Code Review: rails

tfpt review “/shelveset:rails;REDMOND\sborde”
Comment :
Flushes out iconv implementation. Added more specs
Made String#encoding visible only in 1.9 mode
Adds optional paramter to StringScanner.new
The above fixes enable many more Rails tests

Looks good, are the rails tests ready to go into SNAP?

JD

Looks good.

Tomas

Let me run them overnight to catch non-determinstic failures, but they
have been reasonably stable so far.

This forum is not affiliated to the Ruby language, Ruby on Rails framework, nor any Ruby applications discussed here.

| Privacy Policy | Terms of Service | Remote Ruby Jobs