Code Review: rails-2

tfpt review /shelveset:rails-2;REDMOND\jflam

This shelveset introduces fixes that are blocking us from

  • Added missing define_method overload for Proc
  • Adding missing default constructors to StringIO and StringScanner
  • We canonicalize paths returned from a few key File methods (\ -> /)
  • Introducing new Ruby\Libs directory to hold our redirect .rb files and
  • Modifying aliases and checking in ir.cmd
  • Removing .EXE directory from $: search path


In rbconfig.rb:

TOPDIR = File.dirname(FILE).chomp!("/lib/ruby/1.8/i386-mswin32")

the path “/lib/ruby/1.8/i386-mswin32” needs to be replaced by the tail
of the directory path where rbconfig.rb resides.

(otherwise chomp! will return nil)

Cheers, Wayne.

Nice catch! Thanks!


This forum is not affiliated to the Ruby language, Ruby on Rails framework, nor any Ruby applications discussed here.

| Privacy Policy | Terms of Service | Remote Ruby Jobs