Code Review: ProGenFix


#1

tfpt review “/shelveset:ProGenFix;REDMOND\tomat”

DLR, Python, Ruby.

Fixes Ruby calls to protected generic methods.
Adds CompilerHelpers.IsProtected() as an alias for IsFamily ||
IsFamilyOrAssembly.

Tomas


#2

Changes look good overall. I’m not sure that Type.IsProtected() is an
intuitive name; maybe Type.IsNested() would be clearer?


#3

You mean IsNestedProteced()? “Nested” feels superfluous since only
nested types could be protected.

Tomas


#4

Ah, I see. Still, something strikes me as odd about the name, but I
don’t feel strongly about it.