tfpt review “/shelveset:New;REDMOND\tomat”
Mostly Ruby changes and a couple of utility methods in DLR.
Fixes class instantiation, including bug
Several cases need to be distinguished in Class#new:
The class defines or inherits an initializer ("initialize"
method) that is not the default Object#initializer.
a. The initializer is a Ruby method (written in Ruby).
=> Use a default constructor to create the instance and invoke the
initializer on it. If the class derives from CLR class with no default
constructor an exception is thrown.
b. The initializer is defined in a built-in class/module.
The class being instantiated is a Ruby class (deriving from a built-in
Use default constructor and invoke the initializer.
The class is a CLR class.
Use constructor or factory. Do not call the initializer (built-ins must
initialize the object completely in constructors/factories and provide
initializers only for a direct call).
=> Use constructor or factory. Do not call the initializer.
If the first parameter of a CLR constructor is of type RubyClass it is
considered optional and hidden (like RubyContext or RubyScope) and the
binder passes the class object that represents the class being
Adds support for RubyContext hidden parameter to the constructor
generator in RubyTypeBuilder. The first RubyContext or RubyClass
parameter is considered a special hidden parameter. The built type needs
to store RubyClass instance to _class field. If the base constructor
already has RubyClass the derived ctor has the same signature. If the
base constructor takes RubyContext the derived ctor takes RubyClass in
its place and passes its context to the base ctor. If the base ctor
doesn’t have RubyClass or RubyContext parameter RubyClass parameter is
injected. We also need to ensure that we don’t create duplicate
constructors (e.g. if there is a parameter-less overload, an overload
taking RubyContext and an overload taking RubyClass).
Adds unique number to the name of each lambda to avoid duplicate CLR
method names when the code saved to assembly. This removes PEVerifier
Fixes implementation of RubyOverloadResolver.GetParameterCount to count
hidden parameters correctly.