Code Review: MutableStringSqueeze

Ruby IronRuby
1

tfpt review “/shelveset:MutableStringSqueeze;REDMOND\dremy”
Comment :
Implement String.squeeze and String.squeeze!
Passes RubySpec tests. Passes Unit tests.

2

Looks good.

Tomas

3

Should the comment:

“putters putt balls”.squeeze(“mz”) => “puters put balls”

be

“putters putt balls”.squeeze(“m-z”) => “puters put balls”

Robert.

4

Yes! Thanks!

From: [email protected]
[mailto:[email protected]] On Behalf Of Robert Horvick
Sent: Thursday, June 26, 2008 11:15 AM
To: [email protected]
Subject: Re: [Ironruby-core] Code Review: MutableStringSqueeze

Should the comment:

“putters putt balls”.squeeze(“mz”) => “puters put balls”

be

“putters putt balls”.squeeze(“m-z”) => “puters put balls”

Robert.
On Wed, Jun 25, 2008 at 6:55 PM, Dave Remy
<[email protected]mailto:[email protected]> wrote:
tfpt review “/shelveset:MutableStringSqueeze;REDMOND\dremy”
Comment :
Implement String.squeeze and String.squeeze!
Passes RubySpec tests. Passes Unit tests.