Code Review: MoreProtocols8


#1

tfpt review “/shelveset:MoreProtocols8;REDMOND\tomat”

Affects DLR outer ring, IronPython and IronRuby.

DLR:

  • Changes names of arguments/parameters in default binder to be
    typed to strings instead of SymbolIds.

  • Adds NonNullItems attribute. If applied on a params-array or
    dict-array parameter the binder only binds non-null arguments to the
    items of the array/dict.

IronPython:

  • Reflects changes in DLR.

IronRuby:

  • Implements missing protocols and removes all static sites used in
    protocol conversions.

  • Fixes caching issues in protocol conversions.

  • Misc fixes in libraries.

Passed “run 0”.

Tomas


#2

Ruby changes look good.

From: Dino Viehland
Sent: Tuesday, February 17, 2009 2:27 PM
To: Tomas M.; IronRuby External Code R.; Rowan Code
Reviewers; DLR Code Reviews
Cc: removed_email_address@domain.invalid
Subject: RE: Code Review: MoreProtocols8

Python changes look good.

From: Tomas M.
Sent: Tuesday, February 17, 2009 2:02 PM
To: IronRuby External Code R.; Rowan Code R.; DLR Code
Reviews
Cc: removed_email_address@domain.invalid
Subject: Code Review: MoreProtocols8

tfpt review “/shelveset:MoreProtocols8;REDMOND\tomat”

Affects DLR outer ring, IronPython and IronRuby.

DLR:

  • Changes names of arguments/parameters in default binder to be
    typed to strings instead of SymbolIds.

  • Adds NonNullItems attribute. If applied on a params-array or
    dict-array parameter the binder only binds non-null arguments to the
    items of the array/dict.

IronPython:

  • Reflects changes in DLR.

IronRuby:

  • Implements missing protocols and removes all static sites used in
    protocol conversions.

  • Fixes caching issues in protocol conversions.

  • Misc fixes in libraries.

Passed “run 0”.

Tomas