Code Review: MiscStrings

tfpt review “/shelveset:MiscStrings;REDMOND\tomat”

A simple DLR Console Shell change:
The version printed by the console host now recognizes Mono correctly.

Ruby changes:
Ignores UTF8 BOM in 1.8 mode unless $KCODE is SJIS or EUC.
Fixes http://ironruby.codeplex.com/WorkItem/View.aspx?WorkItemId=3913
Fixes -d and --version options.
Fixes a bug in StringScanner: scan doesn’t copy the original string and
[] uses the current value.
Makes MutableString.GetSlice out-of-range tolerant (needed by
StringScanner#[] fix).
Improves performance of repeated Regex.Match called on the same input
string.

Tomas

Ruby tests are fine.

JD


From: Dino Viehland
Sent: Wednesday, March 03, 2010 11:29 AM
To: Tomas M.; IronRuby External Code R.; Rowan Code
Reviewers
Cc: [email protected]
Subject: RE: Code Review: MiscStrings

DLR change looks fine.

  _____________________________________________
  From: Tomas M.
  Sent: Monday, March 01, 2010 6:30 PM
  To: IronRuby External Code R.; Rowan Code R.
  Cc: [email protected]
  Subject: Code Review: MiscStrings


    tfpt review "/shelveset:MiscStrings;REDMOND\tomat"

  A simple DLR Console Shell change:
  The version printed by the console host now recognizes Mono 

correctly.

  Ruby changes:
  Ignores UTF8 BOM in 1.8 mode unless $KCODE is SJIS or EUC.
  Fixes 

http://ironruby.codeplex.com/WorkItem/View.aspx?WorkItemId=3913
Fixes -d and --version options.
Fixes a bug in StringScanner: scan doesn’t copy the original
string and [] uses the current value.
Makes MutableString.GetSlice out-of-range tolerant (needed by
StringScanner#[] fix).
Improves performance of repeated Regex.Match called on the same
input string.

  Tomas


   << File: MiscStrings.diff >>

This forum is not affiliated to the Ruby language, Ruby on Rails framework, nor any Ruby applications discussed here.

| Privacy Policy | Terms of Service | Remote Ruby Jobs