Code Review: FastFixes1

Ruby IronRuby
1

tfpt review “/shelveset:FastFixes1;REDMOND\curth”

Fixed critical error in Dir.glob
Added File.split
Added stub for BigDecimal class

2

Missing a few method return bangs in BigDecimalOps.cs

I guess you’re going to implement Kernel#BigDecimal eventually …

Otherwise looks good!

Thanks,
-John

3

Tomas has already fixed that here :(. As you might imagine, our desire
to astound and amaze the audience at RailsConf has led to some shortcuts
getting taken with respect to the code reviews going out to this list.
This will certainly not be the case post-conference once we start fixing
the “community” part of this “community project”.

Disclaimer: by “astound and amaze” I mean “keep from getting laughed out
of the room”.

4

This bit doesn’t work:

  • [RubyModule(Extends = typeof(Kernel))]
  • public static class KernelOps {
  •    [RubyMethod("BigDecimal",

RubyMethodAttributes.PrivateInstance)]

  •    [RubyMethod("BigDecimal",

RubyMethodAttributes.PublicSingleton)]

  •    public static object CreateBigDecimal(CodeContext/*!*/ context,

object self, [NotNull]MutableString/!/ value) {

  •        return BigDecimalOps.Create(context, value);

  •    }

  •    [RubyMethod("BigDecimal",

RubyMethodAttributes.PrivateInstance)]

  •    [RubyMethod("BigDecimal",

RubyMethodAttributes.PublicSingleton)]

  •    public static object CreateBigDecimal(CodeContext/*!*/ context,

object self, object value) {

  •        return BigDecimalOps.Create(context, value);

  •    }
  • }
    +}

The initializer code builds up the methods nicely but the “Kernel”
module is
not in RubyExecutionContext._moduleCache, so the methods don’t get added
to
Kernel (but instead added to a Module called Ruby::Builtins::Kernel.

Any help here?
Cheers,
Pete

5

Great! No problem.

(I appreciate that this is not a big deal at the moment but I thought I
was
missing something.)

I am continually “astounded and amazed”.

Keep up the hard work. These code reviews, if nothing else, really give
us
a feeling that there is loads of graft going on. Hopefully that will
keep
some of the moaners off your back…

Ta
Pete

6

Hopefully after RailsConf (this weekend) and TechEd (next week). We can
do some work on automating the repository syncing, and setting up a
binary drop. We’ll have to discuss some of those details at that time.

JD