Code Review: Etc module for Mono


git diff attached

  • Implements the Etc module for Mono
  • Adds RubySpec updates for the Etc library
  • Additional updates (dev.sh, ir.sh, many path-related changes) to allow
    *nix devs to run irtests, though this isn’t complete.

Regards,

Ryan R.

Many thanks to Ivan for his dev.sh, ir.sh, and help with many of the
implementation details. Gotta give credit where credit is due. The bad
Ruby
idioms will all be due to me, so just let me know what you need me to
change. :slight_smile:

Ryan R.

Email: [email protected]
LinkedIn: http://www.linkedin.com/in/ryanriley
Blog: http://wizardsofsmart.net/
Twitter: @panesofglass
Website: http://panesofglass.org/

Given that I couldn’t run tests on Mono and I couldn’t figure out how
ROWAN_RUNTIME was used, I went with the cmd_prefix. I can strip that
back
off. As to the mono_debug folder, you’ll need to ask Ivan. I think I
added
the explicit use of that folder, but that’s the folder to which the mono
build was compiling. I’ll check into it again.

Regards,

Ryan

On Sat, Apr 17, 2010 at 9:05 AM, Tomas M. <

In irtests.rb: We already have an environment variable ROWAN_RUNTIME
that is used to run tests on Mono. No need to add cmd_prefix. Just in
your dev.sh set ROWAN_RUNTIME to “mono”. Why do you need to set
debug_folder to mono_debug?
Why couldn’t mono build to the same folders (Debug/V4 Debug) as on
Windows?

Tomas

From: [email protected]
[mailto:[email protected]] On Behalf Of Ryan R.
Sent: Friday, April 16, 2010 11:40 PM
To: [email protected]
Subject: Re: [Ironruby-core] Code Review: Etc module for Mono

Many thanks to Ivan for his dev.sh, ir.sh, and help with many of the
implementation details. Gotta give credit where credit is due. The bad
Ruby idioms will all be due to me, so just let me know what you need me
to change. :slight_smile:

Ryan R.

Email: [email protected]mailto:[email protected]
LinkedIn: http://www.linkedin.com/in/ryanriley
Blog: http://wizardsofsmart.net/
Twitter: @panesofglass
Website: http://panesofglass.org/

On Fri, Apr 16, 2010 at 11:35 PM, Ryan R.
<[email protected]mailto:[email protected]> wrote:
http://github.com/panesofglass/ironruby
git diff attached

  • Implements the Etc module for Mono
  • Adds RubySpec updates for the Etc library
  • Additional updates (dev.sh, ir.sh, many path-related changes) to allow
    *nix devs to run irtests, though this isn’t complete.

Regards,

Ryan R.

When I build on mono with rake compile, the debug folder created is
called
mono_debug. I don’t think I added that myself, just in the irtest.rb
file.
As to the ROWAN_RUNTIME, where is that set? I don’t see it in the
Dev.bat
file.

Thanks,

Ryan R.

Email: [email protected]
LinkedIn: http://www.linkedin.com/in/ryanriley
Blog: http://wizardsofsmart.net/
Twitter: @panesofglass
Website: http://panesofglass.org/

If you pass mono arguments to dev.bat it will set it like so:

REM – Mono
if “%1” == “mono” (
set ROWAN_RUNTIME=mono
if NOT EXIST %2\mono.exe (
echo Error: Mono Runtime not found at %2
goto END
)
)
REM Do not encapsulate this if-statement in parentheses, they might
interact with %PATH% if it contains (x86):
if “%1” == “mono” set PATH=%PATH%;%2

So on Windows you can have 2 shortcuts: one for Mono environment and one
for .NET environment.

Tomas

From: [email protected]
[mailto:[email protected]] On Behalf Of Ryan R.
Sent: Sunday, April 18, 2010 3:16 PM
To: [email protected]
Subject: Re: [Ironruby-core] Code Review: Etc module for Mono

When I build on mono with rake compile, the debug folder created is
called mono_debug. I don’t think I added that myself, just in the
irtest.rb file. As to the ROWAN_RUNTIME, where is that set? I don’t see
it in the Dev.bat file.

Thanks,

Ryan R.

Email: [email protected]mailto:[email protected]
LinkedIn: http://www.linkedin.com/in/ryanriley
Blog: http://wizardsofsmart.net/
Twitter: @panesofglass
Website: http://panesofglass.org/

On Sun, Apr 18, 2010 at 2:13 PM, Ryan R.
<[email protected]mailto:[email protected]> wrote:
Given that I couldn’t run tests on Mono and I couldn’t figure out how
ROWAN_RUNTIME was used, I went with the cmd_prefix. I can strip that
back off. As to the mono_debug folder, you’ll need to ask Ivan. I think
I added the explicit use of that folder, but that’s the folder to which
the mono build was compiling. I’ll check into it again.

Regards,

Ryan
On Sat, Apr 17, 2010 at 9:05 AM, Tomas M.
<[email protected]mailto:[email protected]>
wrote:
In irtests.rb: We already have an environment variable ROWAN_RUNTIME
that is used to run tests on Mono. No need to add cmd_prefix. Just in
your dev.sh set ROWAN_RUNTIME to “mono”. Why do you need to set
debug_folder to mono_debug?
Why couldn’t mono build to the same folders (Debug/V4 Debug) as on
Windows?

Tomas

From:
[email protected]mailto:removed_em[email protected]
[mailto:[email protected]mailto:[email protected]]
On Behalf Of Ryan R.
Sent: Friday, April 16, 2010 11:40 PM

To: [email protected]mailto:[email protected]
Subject: Re: [Ironruby-core] Code Review: Etc module for Mono

Many thanks to Ivan for his dev.sh, ir.sh, and help with many of the
implementation details. Gotta give credit where credit is due. The bad
Ruby idioms will all be due to me, so just let me know what you need me
to change. :slight_smile:

Ryan R.

Email: [email protected]mailto:[email protected]
LinkedIn: http://www.linkedin.com/in/ryanriley
Blog: http://wizardsofsmart.net/
Twitter: @panesofglass
Website: http://panesofglass.org/
On Fri, Apr 16, 2010 at 11:35 PM, Ryan R.
<[email protected]mailto:[email protected]> wrote:
http://github.com/panesofglass/ironruby
git diff attached

  • Implements the Etc module for Mono
  • Adds RubySpec updates for the Etc library
  • Additional updates (dev.sh, ir.sh, many path-related changes) to allow
    *nix devs to run irtests, though this isn’t complete.

Regards,

Ryan R.


Ironruby-core mailing list
[email protected]mailto:[email protected]
http://rubyforge.org/mailman/listinfo/ironruby-core

This forum is not affiliated to the Ruby language, Ruby on Rails framework, nor any Ruby applications discussed here.

| Privacy Policy | Terms of Service | Remote Ruby Jobs