Code Review: DirFix

Ruby IronRuby
1

Tfpt review /shelveset:DirFix;srivatsn

Fixes RubyForge [#21126] Dir.glob **/ returns duplicate entries.

The code was enumerating the current folder’s and its subfolders’ files
recursively and hence everything got counted twice. The fix tracks that
with a flag.

2

Looks good.

Tomas

From: Srivatsn Narayanan
Sent: Monday, August 25, 2008 12:41 PM
To: IronRuby External Code R.
Cc: [email protected]
Subject: Code Review: DirFix

Tfpt review /shelveset:DirFix;srivatsn

Fixes RubyForge [#21126] Dir.glob **/ returns duplicate entries.

The code was enumerating the current folder’s and its subfolders’ files
recursively and hence everything got counted twice. The fix tracks that
with a flag.