Code Review: Dir4

tfpt review “/shelveset:Dir4;REDMOND\tomat”
Comment :
DLR, Python:

  • Adds more file system APIs to PAL. Obsoletes virtual methods
    GetFiles and GetDirectories in favor of GetFileSystemEntries.


  • Fixes some Dir specs, adds support for Unicode file/directory
  • Changes Dir and File methods to use PAL for file system operations.
    Adds Dir tests exercising a custom virtual file system.
  • Fixes encoding of file paths. This might fix some of the reported
    System::Text::DecoderFallbackException issues
  • Fixes issues with -v command line option.
  • Fixes bugs in methods using MutableString.GetByteArray.
  • Fixes MutableString#inspect and dump to handle strings with
    incomplete UTF16 characters.
  • Fixes bugs in glob.


I know I’m late on this, but test looks good too.