Code Review: dash_s

jsoho · January 17, 2010, 11:58am

-S finds the file being run on the environment’s PATH, rather than
requiring the full path to be provided.

jsoho · January 18, 2010, 8:26am

I noticed that -S should use the first file it finds on the path, can
you do a spec for that?

The rest looks good.

JD

jsoho · January 19, 2010, 8:24pm

Looks good. Could you factor the file search out into a private method?

Tomas

jsoho · January 25, 2010, 7:37am

Could you factor the file search out into a private method?

Done …

I noticed that -S should use the first file it finds on the path, can
you do a spec for that?

… and done (though, isn’t that the definition of the path? =P)

Attached diff, or
tfpt review “/shelveset:dash_upper_s;REDMOND\jimmysch”

~Jimmy