Code Review: dash_s

-S finds the file being run on the environment’s PATH, rather than
requiring the full path to be provided.

Adds the -S command-line option (for example: ir -S irb)
http://github.com/jschementi/ironruby/commit/135d5e5715409a194191c51c0566863603f49e16

Add spec for -S
http://github.com/jschementi/ironruby/commit/62f211de25d1e7c7793b4f9af36cfde3670247f8

I noticed that -S should use the first file it finds on the path, can
you do a spec for that?

The rest looks good.

JD

Looks good. Could you factor the file search out into a private method?

Tomas

Could you factor the file search out into a private method?

Done …

I noticed that -S should use the first file it finds on the path, can
you do a spec for that?

… and done (though, isn’t that the definition of the path? =P)

Attached diff, or
tfpt review “/shelveset:dash_upper_s;REDMOND\jimmysch”

~Jimmy

This forum is not affiliated to the Ruby language, Ruby on Rails framework, nor any Ruby applications discussed here.

| Privacy Policy | Terms of Service | Remote Ruby Jobs