Code Review: crit_argf

tfpt review “/shelveset:crit_argf;REDMOND\jdeville”
Comment :
cleans up a few critical tags:

  • re-patches mock.rb with the patch to remove respond_to last
  • implements a basic implementation of ARGF, there are many holes that
    still need to be filled here, but the basic idea works, and the specs
    are no longer critical.

Could you add comments “TODO: thread safety” to the added fields. There
are several places that access them in thread unsafe way.
Could you also replace
return
MutableString.CreateAscii(CommandLineArguments[_currentFileIndex].ToString());
with
// TODO: convert any non-string
return
(MutableString)CommandLineArguments[_currentFileIndex];
?

Tomas

Will do.

This forum is not affiliated to the Ruby language, Ruby on Rails framework, nor any Ruby applications discussed here.

| Privacy Policy | Terms of Service | Remote Ruby Jobs