Code Review: BacktraceFix

Ruby IronRuby
1

tfpt review “/shelveset:BacktraceFix;REDMOND\tomat”
Comment :
Backtraces weren’t handled correctly for rethrown exceptions.
Adds some tests for backtraces and modifies the infrastructure to run
unit tests in all combinations of /interpret and /partial modes.

Tomas

2

Test changes look good.

JD

From: [email protected]
[[email protected]] On Behalf Of Tomas M.
[[email protected]]
Sent: Tuesday, September 30, 2008 5:26 PM
To: IronRuby External Code R.
Cc: [email protected]
Subject: [Ironruby-core] Code Review: BacktraceFix

tfpt review “/shelveset:BacktraceFix;REDMOND\tomat”
Comment :
Backtraces weren’t handled correctly for rethrown exceptions.
Adds some tests for backtraces and modifies the infrastructure to run
unit tests in all combinations of /interpret and /partial modes.

Tomas

3

Both overloads of RubyExceptionData.AddBacktrace take skipFrames as a
reference parameter, but it doesn’t look like any of the call sites care
about the modified value. Looks good otherwise.

4

One of the overload is called in CreateBacktrace and ref skipFrames is
used there.
You’re right about the other overload. I used the same pattern for
consistency.

Tomas