Code Review: Allows symbols to be in a YAML array


#1

http://github.com/jschementi/ironruby/commit/e8406f60c9426f4b675bf67180c24f2bb5b0f609

Allows symbols to be in a YAML array (“date: [:year, :month, :day]”).
Fixes http://ironruby.codeplex.com/WorkItem/View.aspx?WorkItemId=375.

(Shri: gitdiff wasn’t working for me, is there any setup I need to do?)


#2

GitDiff.bat just builds on top of the GIT_EXTERNAL_DIFF environment
variable mentioned at
http://kernel.org/pub/software/scm/git/docs/v1.0.13/git-diff-files.html.
Can you do “set GIT_EXTERNAL_DIFF=echo” and then run a “git diff”
command. If that runs to completion, GitDiff.bat should work as well. We
can take a look tomorrow…

Shri

From: Jimmy S.
Sent: Saturday, April 11, 2009 4:42 PM
To: removed_email_address@domain.invalid
Cc: IronRuby External Code R.
Subject: Code Review: Allows symbols to be in a YAML array

http://github.com/jschementi/ironruby/commit/e8406f60c9426f4b675bf67180c24f2bb5b0f609

Allows symbols to be in a YAML array (“date: [:year, :month, :day]”).
Fixes http://ironruby.codeplex.com/WorkItem/View.aspx?WorkItemId=375.

(Shri: gitdiff wasn’t working for me, is there any setup I need to do?)


#3

In the spec, why not use each_with_index instead of times?
(http://github.com/jschementi/ironruby/commit/e8406f60c9426f4b675bf67180c24f2bb5b0f609#L1R99)

Other than that, looks good.

JD

From: Jimmy S.
Sent: Saturday, April 11, 2009 4:42 PM
To: removed_email_address@domain.invalid
Cc: IronRuby External Code R.
Subject: Code Review: Allows symbols to be in a YAML array

http://github.com/jschementi/ironruby/commit/e8406f60c9426f4b675bf67180c24f2bb5b0f609

Allows symbols to be in a YAML array (“date: [:year, :month, :day]”).
Fixes http://ironruby.codeplex.com/WorkItem/View.aspx?WorkItemId=375.

(Shri: gitdiff wasn’t working for me, is there any setup I need to do?)


#4

File.dirname now uses [NotNull] instead of an explicit check on path:
http://github.com/jschementi/ironruby/commit/8235f4861f0afb70c504472e697565080ffdb3c8
Jim said spec changes were fine. This is in my master github branch now,
and Jim is pulling it in to the main repo shortly.

One more bug fix (autoload) left until Rails starts!

From: Jim D.
Sent: Tuesday, April 14, 2009 11:45 AM
To: Jimmy S.; removed_email_address@domain.invalid
Cc: IronRuby External Code R.
Subject: RE: Code Review: Allows symbols to be in a YAML array

In the spec, why not use each_with_index instead of times?
(http://github.com/jschementi/ironruby/commit/e8406f60c9426f4b675bf67180c24f2bb5b0f609#L1R99)

Other than that, looks good.

JD

From: Jimmy S.
Sent: Saturday, April 11, 2009 4:42 PM
To: removed_email_address@domain.invalid
Cc: IronRuby External Code R.
Subject: Code Review: Allows symbols to be in a YAML array

http://github.com/jschementi/ironruby/commit/e8406f60c9426f4b675bf67180c24f2bb5b0f609

Allows symbols to be in a YAML array (“date: [:year, :month, :day]”).
Fixes http://ironruby.codeplex.com/WorkItem/View.aspx?WorkItemId=375.

(Shri: gitdiff wasn’t working for me, is there any setup I need to do?)