Bug fixes for nginx-1.0.4

Hi:

I could not upload and put into development forum. So I place it
here.

I ran configure with

#export SPATH=/home/s

./configure --prefix=${SPATH}

\
        --sbin-path=${SPATH}/bin/ngnix


–conf-path=${SPATH}/src/param/ngnix/ngnix.conf

–error-log-path=${SPATH}/logs/ngnix-error.conf

–pid-path=${SPATH}/logs/nginx.pid

–lock-path=${SPATH}/logs/nginx.lock

–http-log-path=${SPATH}/logs/ngnix-access.log

–http-client-body-temp-path=${SPATH}/html/temp/client_body

–http-proxy-temp-path=${SPATH}/html/temp/proxy

–http-fastcgi-temp-path=${SPATH}/html/temp/fastcgi

–http-uwsgi-temp-path=${SPATH}/html/temp/uwsgi

–http-scgi-temp-path=${SPATH}/html/temp/scgi

–builddir=${SPATH}/src/build/xnpp/ngnix

–with-http_ssl_module

Bug 1:

The directories
a) NGX_HTTP_PROXY_TEMP_PATH
b) NGX_HTTP_FASTCGI_TEMP_PATH
c) NGX_HTTP_FASTCGI_TEMP_PATH
d) NGX_HTTP_UWSGI_TEMP_PATH

are not created by Makefile.

nginx-1.0.4/auto/install
74a75,113

case “.$NGX_HTTP_PROXY_TEMP_PATH” in
./*)
;;

*)

NGX_HTTP_PROXY_TEMP_PATH=$NGX_PREFIX/$NGX_HTTP_PROXY_TEMP_PATH

;;

esac

case “.$NGX_HTTP_FASTCGI_TEMP_PATH” in
./*)
;;

*)

NGX_HTTP_FASTCGI_TEMP_PATH=$NGX_PREFIX/$NGX_HTTP_FASTCGI_TEMP_PATH

;;

esac

case “.$NGX_HTTP_UWSGI_TEMP_PATH” in
./*)
;;

*)

NGX_HTTP_UWSGI_TEMP_PATH=$NGX_PREFIX/$NGX_HTTP_UWSGI_TEMP_PATH

;;

esac

case “.$NGX_HTTP_SCGI_TEMP_PATH” in
./*)
;;

*)
    NGX_HTTP_SCGI_TEMP_PATH=$NGX_PREFIX/$NGX_HTTP_SCGI_TEMP_PATH
;;

esac

136a176,187

test -d ‘$(DESTDIR)$NGX_HTTP_SCGI_TEMP_PATH’ ||
mkdir -p ‘$(DESTDIR)$NGX_HTTP_SCGI_TEMP_PATH’

Bug 2:

If --builddir is two level depth, it is not created by Makefile.

nginx-1.0.4/configure
10c10
< test -d $NGX_OBJS || mkdir $NGX_OBJS

test -d $NGX_OBJS || mkdir -p $NGX_OBJS

Posted at Nginx Forum:
http://forum.nginx.org/read.php?2,208219,208219#msg-208219

Hello!

On Sun, Jun 19, 2011 at 09:42:32AM -0400, yoonghm wrote:

I could not upload and put into development forum. So I place it
here.

There is no such thing as “development forum”. There is
development mailing list, and it’s intentionally only read-only in
forum interface. Use mailing list as a mailing list.

[…]

Bug 1:

The directories
a) NGX_HTTP_PROXY_TEMP_PATH
b) NGX_HTTP_FASTCGI_TEMP_PATH
c) NGX_HTTP_FASTCGI_TEMP_PATH
d) NGX_HTTP_UWSGI_TEMP_PATH

are not created by Makefile.

They aren’t expected to.

These and other paths will be created by nginx binary on startup
(if not redefined with configuration and/or command line options).

Bug 2:

If --builddir is two level depth, it is not created by Makefile.

nginx-1.0.4/configure
10c10
< test -d $NGX_OBJS || mkdir $NGX_OBJS

test -d $NGX_OBJS || mkdir -p $NGX_OBJS

No objections here.

But please, use unified diffs when posting patches. Recommended
diff command line is “diff -up”.

Maxim D.

This forum is not affiliated to the Ruby language, Ruby on Rails framework, nor any Ruby applications discussed here.

| Privacy Policy | Terms of Service | Remote Ruby Jobs