[Bug #3384] ext/openssl: avoid to use cast

Ruby Development
#1

Bug #3384: ext/openssl: avoid to use cast
http://redmine.ruby-lang.org/issues/show/3384

e$B5/I<<Te(B: Takahiro K.
e$B%9%F!<%?%9e(B: Open, e$BM%@hEYe(B: Normal
ruby -v: ruby 1.9.2dev (2010-05-31 revision 28117) [i486-netbsdelf]

ext/openssle$B$G!"$3$NItJ,[email protected]$15lMh$Ne(Bcaste$B$r;HMQ$7$F$$$k$N$O2?$+M}M3$,$"$k$N$G$7$g$&$+e(B?

— ext/openssl/ossl_ssl.c.orig 2010-05-23 12:18:51.000000000 +0000
+++ ext/openssl/ossl_ssl.c
@@ -700,10 +700,10 @@ ossl_sslctx_get_ciphers(VALUE self)
if (!ciphers)
return rb_ary_new();

  • num = sk_num((STACK*)ciphers);
  • num = sk_SSL_CIPHER_num(ciphers);
    ary = rb_ary_new2(num);
    for(i = 0; i < num; i++){
  •    cipher = (SSL_CIPHER*)sk_value((STACK*)ciphers, i);

  •    cipher = sk_SSL_CIPHER_value(ciphers, i);
   rb_ary_push(ary, ossl_ssl_cipher_to_ary(cipher));
    }
    return ary;
#2

e$B%A%1%C%He(B #3384 e$B$,99?7$5$l$^$7$?!#e(B (by Yusuke E.)

e$B1sF#$G$9!#e(B

ext/openssle$B$G!"$3$NItJ,[email protected]$15lMh$Ne(Bcaste$B$r;HMQ$7$F$$$k$N$O2?$+M}M3$,$"$k$N$G$7$g$&$+e(B?

cast e$B$r;HMQ$7$F$$$k$HLdBj$,$"$k$G$7$g$&$+!#e(B
e$B%3%s%Q%$%i$,[email protected]$H$7$?$i!":#$O2<<j$K$$$8$j$?$/e(B
e$B$J$$$J$H;W$$$^$9!#e(B

–
Yusuke E. [email protected]

http://redmine.ruby-lang.org/issues/show/3384

#3

e$B%A%1%C%He(B #3384 e$B$,99?7$5$l$^$7$?!#e(B (by Yui NARUSE)

e$BB>$NItJ,$OJQ$($J$$$H%3%s%Q%$%k$,DL$i$J$+$C$?$N$KBP$7!"$3$3$OJQ$($J$/$F$bDL$C$?$+$i$8$c$J$$$+$J$!$H;W$$$^$9!#e(B

http://redmine.ruby-lang.org/issues/show/3384

#4

e$B%A%1%C%He(B #3384 e$B$,99?7$5$l$^$7$?!#e(B (by Takahiro K.)

cast e$B$r;HMQ$7$F$$$k$HLdBj$,$"$k$G$7$g$&$+!#e(B
e$B$=$&[email protected]$o$l$F$7$^$&$H?H$b38$b$"$j$^$;$s!#K\Mh$Ne(BOpenSSLe$B$,Ds6!$7$F$$$ke(BAPIe$B$rHr$1$F!"%-%c%9%H$r;H$$B3$1$k$N$O$I$&[email protected]$m$&$H;W$C$?<!Bh$G$9!#>-Mh$Ne(BOpenSSLe$B$N%j%j!<%9$K8~$1$?0?"@-$H$$$&LL$G$O3N<B$KITMx$G$O$J$$$G$7$g$&$+e(B?

e$B:#$O2<<j$K$$$8$j$?$/$J$$$J$H;W$$$^$9!#e(B
1.9.2e$B$N%j%j!<%9$^[email protected]$7$FM_$7$$$H$b;W$C$F$O$$$^$;$s!#e(B

http://redmine.ruby-lang.org/issues/show/3384

#5

e$B%A%1%C%He(B #3384 e$B$,99?7$5$l$^$7$?!#e(B (by Yui NARUSE)

e$B%9%F!<%?%9e(B Opene$B$+$ie(BClosede$B$KJQ99e(B
e$B?JD=e(B % 0e$B$+$ie(B100e$B$KJQ99e(B

This issue was solved with changeset r28282.
Takahiro, thank you for reporting this issue.
Your contribution to Ruby is greatly appreciated.
May Ruby be with you.

http://redmine.ruby-lang.org/issues/show/3384

#6

e$B%A%1%C%He(B #3384 e$B$,99?7$5$l$^$7$?!#e(B (by Yui NARUSE)

http://cvs.openssl.org/fileview?f=openssl/crypto/stack/safestack.h&v=1.14
e$B$GF~$C$?e(BAPIe$B$N$h$&$J$N$G!"C1$K8E$$$^$^;[email protected]$1$N$h$&$G$9$M!#e(B
e$B$J$N$Ge(Btrunke$B$K$O<h9~$_$^$9!#e(B

http://redmine.ruby-lang.org/issues/show/3384