[Bug #3316] Kernel#caller returns nil as well

Nobuhiro_IMAI · May 19, 2010, 5:49am

Bug #3316: Kernel#caller returns nil as well
http://redmine.ruby-lang.org/issues/show/3316

e$B5/I<<Te(B: Nobuhiro IMAI
e$B%9%F!<%?%9e(B: Open, e$BM%@hEYe(B: Normal
e$B%+%F%4%je(B: DOC
ruby -v: -

[ruby-dev:41330] e$B$N7o$G$9$,!"%H%C%W%l%Y%k1>!9$OCV$$$H$$$F!“e(B
nil e$B$,JV$k$3$H$b$”$k$H$$$&$N$re(B RDoc e$B$K=q$$$F$_$^$7$?!#e(B
trunk e$B$de(B branches/ruby_1_9_2 e$B$K$=$N$^$^Ev$?$k$H;W$$$^$9!#e(B

Nobuhiro_IMAI · May 19, 2010, 1:06pm

e$B1sF#$G$9!#e(B

2010e$BG/e(B5e$B7ne(B19e$BF|e(B12:49 Nobuhiro IMAI
[email protected]:

[ruby-dev:41330] e$B$N7o$G$9$,!"%H%C%W%l%Y%k1>!9$OCV$$$H$$$F!“e(B
nil e$B$,JV$k$3$H$b$”$k$H$$$&$N$re(B RDoc e$B$K=q$$$F$_$^$7$?!#e(B

e$BH?1~$,CY$/$F$9$_$^$;$s!#e(B

e$B8+$?$H$3$me(B r21932 e$B$GF~$C$?JQ99$N$h$&$G$9$,!"e(BChangeLog
e$B$K$h$k$He(B
e$B:GE,2=$+%j%U%!%/%?%j%s%0$r0U?^$7$?$b$N$N$h$&$G!"5sF0JQ99<+BN$Oe(B
e$B0U?^$7$F$$$J$+$C$?$b$N$H;W$$$^$9!#e(B
e$B%H%C%W%l%Y%k$G$O6uG[Ns$rJV$9$h$&$K=$@5$7$F$*$-$^$9!#e(B

diff --git a/vm_eval.c b/vm_eval.c
index 2bf640d…d1e6352 100644
— a/vm_eval.c
+++ b/vm_eval.c
@@ -1562,7 +1562,7 @@ rb_catch_obj(VALUE tag, VALUE (*func)(), VALUE
data)
static VALUE
rb_f_caller(int argc, VALUE *argv)
{

VALUE level;

VALUE level, ary;
int lev;

rb_scan_args(argc, argv, “01”, &level);
@@ -1574,7 +1574,9 @@ rb_f_caller(int argc, VALUE *argv)
if (lev < 0)
rb_raise(rb_eArgError, “negative level (%d)”, lev);

return vm_backtrace(GET_THREAD(), lev);

ary = vm_backtrace(GET_THREAD(), lev);
if (NIL_P(ary)) ary = rb_ary_new();
return ary;
}

static int

Nobuhiro_IMAI · May 19, 2010, 1:27pm

e$B%A%1%C%He(B #3316 e$B$,99?7$5$l$^$7$?!#e(B (by Yusuke E.)

e$B%9%F!<%?%9e(B Opene$B$+$ie(BClosede$B$KJQ99e(B
e$B?JD=e(B % 0e$B$+$ie(B100e$B$KJQ99e(B

This issue was solved with changeset r27895.
Nobuhiro, thank you for reporting this issue.
Your contribution to Ruby is greatly appreciated.
May Ruby be with you.

http://redmine.ruby-lang.org/issues/show/3316

Nobuhiro_IMAI · May 19, 2010, 9:47pm

e$B$$$^$$$G$9!#e(B

From: Yusuke ENDOH <mame_at_tsg.ne.jp>
Date: Wed, 19 May 2010 20:05:45 +0900

e$B8+$?$H$3$me(B r21932 e$B$GF~$C$?JQ99$N$h$&$G$9$,!"e(BChangeLog e$B$K$h$k$He(B
e$B:GE,2=$+%j%U%!%/%?%j%s%0$r0U?^$7$?$b$N$N$h$&$G!"5sF0JQ99<+BN$Oe(B
e$B0U?^$7$F$$$J$+$C$?$b$N$H;W$$$^$9!#e(B
e$B%H%C%W%l%Y%k$G$O6uG[Ns$rJV$9$h$&$K=$@5$7$F$*$-$^$9!#e(B

e$B$"$j$,$H$&$4$6$$$^$9!#e(B

e$B$,!"$3$l$@$H!"e(Bcaller(0)
e$B$GJV$kG[Ns$N%5%$%:$r1[$($k?t$r0z?t$H$7$FEO$7$Fe(B
e$B$b6uG[Ns$,JV$k$h$&$K$J$C$F$7$^$C$F$$$k$h$&$G$9!#e(B

$ ruby1.8 -ve ‘p [caller(0), caller(1), caller(2)]’
ruby 1.8.8dev (2010-05-17 revision 26358) [i686-linux]
[["-e:1"], [], nil]
^^^
$ ruby1.9 -ve 'p [caller(0), caller(1), caller(2)]
‘ruby 1.9.3dev (2010-05-20 trunk 27911) [i686-linux]
[["-e:1:in `’"], [], []]
^^

caller(0)[start…-1] e$B$H$$$&$3$H$J$N$+$J!#e(B

Nobuhiro_IMAI · May 20, 2010, 2:59pm

e$B1sF#$G$9!#e(B

2010e$BG/e(B5e$B7ne(B20e$BF|e(B4:47 Nobuhiro IMAI [email protected]:

e$B$,!"$3$l$@$H!"e(Bcaller(0) e$B$GJV$kG[Ns$N%5%$%:$r1[$($k?t$r0z?t$H$7$FEO$7$Fe(B
e$B$b6uG[Ns$,JV$k$h$&$K$J$C$F$7$^$C$F$$$k$h$&$G$9!#e(B

e$B$0$“$”!“LdBj$r8m2r$7$F$$$^$7$?!#e(Bnil
e$B$,5”$k$3$H$,$"$k$N$O85$+$i$J$s$G$9$M!#e(B
e$B0J2<$N%Q%C%A$G:FD)@o$7$^$9!#$=$l$+$iD:$$$?%Q%C%A$O<h$j9~$s$G$*$-$^$9!#e(B

diff --git a/vm.c b/vm.c
index 084c8c8…ac1d8ed 100644
— a/vm.c
+++ b/vm.c
@@ -706,19 +706,20 @@ rb_vm_get_sourceline(const rb_control_frame_t
*cfp)
}

static int
-vm_backtrace_each(rb_thread_t *th, int lev, rb_backtrace_iter_func
*iter, void *arg)
+vm_backtrace_each(rb_thread_t *th, int lev, void (*init)(void *),
rb_backtrace_iter_func *iter, void *arg)
{
const rb_control_frame_t *limit_cfp = th->cfp;
const rb_control_frame_t *cfp = (void *)(th->stack +
th->stack_size);

VALUE file = Qnil;

VALUE file = Qnil, *aryp = arg;
int line_no = 0;

cfp -= 2;
while (lev-- >= 0) {

if (++limit_cfp >= cfp) {

if (++limit_cfp > cfp) {
return FALSE;
}
}
if (init) (*init)(arg);
limit_cfp = RUBY_VM_NEXT_CONTROL_FRAME(limit_cfp);
if (th->vm->progname) file = th->vm->progname;
while (cfp > limit_cfp) {
@@ -747,15 +748,19 @@ vm_backtrace_each(rb_thread_t *th, int lev,
rb_backtrace_iter_func *iter, void *
return TRUE;
}

+static void
+vm_backtrace_alloc(void *arg)
+{

VALUE *aryp = arg;
*aryp = rb_ary_new();
+}

static int
vm_backtrace_push(void *arg, VALUE file, int line_no, VALUE name)
{
VALUE *aryp = arg;
VALUE bt;

if (!*aryp) {
*aryp = rb_ary_new();
}
bt = rb_enc_sprintf(rb_enc_compatible(file, name), “%s:%d:in `%s’”,
RSTRING_PTR(file), line_no, RSTRING_PTR(name));
rb_ary_push(*aryp, bt);
@@ -770,7 +775,7 @@ vm_backtrace(rb_thread_t *th, int lev)
if (lev < 0) {
ary = rb_ary_new();
}
vm_backtrace_each(th, lev, vm_backtrace_push, &ary);

vm_backtrace_each(th, lev, vm_backtrace_alloc, vm_backtrace_push,
&ary);
if (!ary) return Qnil;
return rb_ary_reverse(ary);
}
diff --git a/vm_eval.c b/vm_eval.c
index d1e6352…b854efc 100644
— a/vm_eval.c
+++ b/vm_eval.c
@@ -16,7 +16,7 @@ static inline VALUE rb_vm_set_finish_env(rb_thread_t *
th);
static inline VALUE vm_yield_with_cref(rb_thread_t *th, int argc,
const VALUE *argv, const NODE *cref);
static inline VALUE vm_yield(rb_thread_t *th, int argc, const VALUE
*argv);
static inline VALUE vm_backtrace(rb_thread_t *th, int lev);
-static int vm_backtrace_each(rb_thread_t *th, int lev,
rb_backtrace_iter_func *iter, void *arg);
+static int vm_backtrace_each(rb_thread_t *th, int lev, void
(*init)(void *), rb_backtrace_iter_func *iter, void *arg);
static NODE *vm_cref_push(rb_thread_t *th, VALUE klass, int noex,
rb_block_t *blockptr);
static VALUE vm_exec(rb_thread_t *th);
static void vm_set_eval_stack(rb_thread_t * th, VALUE iseqval, const
NODE *cref);
@@ -1574,9 +1574,7 @@ rb_f_caller(int argc, VALUE *argv)
if (lev < 0)
rb_raise(rb_eArgError, “negative level (%d)”, lev);

ary = vm_backtrace(GET_THREAD(), lev);
if (NIL_P(ary)) ary = rb_ary_new();
return ary;

return vm_backtrace(GET_THREAD(), lev);
}

static int
@@ -1598,7 +1596,7 @@ print_backtrace(void *arg, VALUE file, int line,
VALUE method)
void
rb_backtrace(void)
{

vm_backtrace_each(GET_THREAD(), -1, print_backtrace, stderr);

vm_backtrace_each(GET_THREAD(), -1, NULL, print_backtrace, stderr);
}

VALUE
@@ -1629,7 +1627,7 @@ rb_thread_backtrace(VALUE thval)
int
rb_backtrace_each(rb_backtrace_iter_func *iter, void *arg)
{

return vm_backtrace_each(GET_THREAD(), -1, iter, arg);

return vm_backtrace_each(GET_THREAD(), -1, NULL, iter, arg);
}

/*

Nobuhiro_IMAI · May 24, 2010, 6:45pm

e$B1sF#$G$9!#e(B

2010e$BG/e(B5e$B7ne(B22e$BF|e(B0:59 Nobuhiro IMAI [email protected]:

e$B$3$l$G!“e(B1.8 e$B$HF1$85sF0$K$J$C$F$$$k$H;W$$$^$9!#$H$$$&Lu$G!”$;$C$+$/%Q%Ce(B
e$B%A$r<h$j9~$s$G$$$?$@$$$?$N$K!"e(BRDoc e$B$NJ}$,4V0c$$$K$J$C$F$7$^$$$^$7$?!#e(B

e$B$&$“$”!#e(B

e$B0J2<$N%Q%C%A$G@5$7$$5-=R$K$J$k$H;W$$$^$9!#$D$$$G$K!"e(B

e$BB>$N>l=j$K9g$o$;$Fe(B s/Array/array/

e$B<B:]$N=PNO$K9g$o$;$Fe(B in `’ e$B$rDI2Ce(B

caller(4) e$B$r=$@5!"e(Bcaller(5) e$B$rDI2Ce(B

e$B$H$$$&JQ99$r2C$($F$$$^$9!#9g$o$;$F<h<NA*Br$7$F$/$@$5$$!#e(B

e$B$"$j$,$H$&$4$6$$$^$9!#$4$C$=$j<h$j9~$_$^$9!#e(B

Nobuhiro_IMAI · May 21, 2010, 5:59pm

e$B$$$^$$$G$9!#e(B

From: Yusuke ENDOH <mame_at_tsg.ne.jp>
Date: Thu, 20 May 2010 21:58:42 +0900

e$B1sF#$G$9!#e(B

2010e$BG/e(B5e$B7ne(B20e$BF|e(B4:47 Nobuhiro IMAI [email protected]:

e$B$,!"$3$l$@$H!"e(Bcaller(0) e$B$GJV$kG[Ns$N%5%$%:$r1[$($k?t$r0z?t$H$7$FEO$7$Fe(B
e$B$b6uG[Ns$,JV$k$h$&$K$J$C$F$7$^$C$F$$$k$h$&$G$9!#e(B

e$B$0$“$”!“LdBj$r8m2r$7$F$$$^$7$?!#e(Bnil e$B$,5”$k$3$H$,$"$k$N$O85$+$i$J$s$G$9$M!#e(B
e$B0J2<$N%Q%C%A$G:FD)@o$7$^$9!#$=$l$+$iD:$$$?%Q%C%A$O<h$j9~$s$G$*$-$^$9!#e(B

e$B%H%C%W%l%Y%k1>!9$NOC$G:.Mp$5$;$F$7$^$C$?$+$b$7$l$^$;$s!#$4$a$s$J$5$$!#e(B

e$B$3$l$G!“e(B1.8
e$B$HF1$85sF0$K$J$C$F$$$k$H;W$$$^$9!#$H$$$&Lu$G!”$;$C$+$/%Q%Ce(B
e$B%A$r<h$j9~$s$G$$$?$@$$$?$N$K!"e(BRDoc
e$B$NJ}$,4V0c$$$K$J$C$F$7$^$$$^$7$?!#e(B
e$B0J2<$N%Q%C%A$G@5$7$$5-=R$K$J$k$H;W$$$^$9!#$D$$$G$K!"e(B

e$BB>$N>l=j$K9g$o$;$Fe(B s/Array/array/
e$B<B:]$N=PNO$K9g$o$;$Fe(B in `’ e$B$rDI2Ce(B
caller(4) e$B$r=$@5!"e(Bcaller(5) e$B$rDI2Ce(B

e$B$H$$$&JQ99$r2C$($F$$$^$9!#9g$o$;$F<h<NA*Br$7$F$/$@$5$$!#e(B

Nobuhiro IMAI [email protected]
Key fingerprint = F39E D552 545D 7C64 D690 F644 5A15 746C BD8E 7106

diff --git a/vm_eval.c b/vm_eval.c
index cff05a0…e609ca0 100644
— a/vm_eval.c
+++ b/vm_eval.c
@@ -1536,7 +1536,7 @@ rb_catch_obj(VALUE tag, VALUE (*func)(), VALUE
data)

/*

call-seq:

- ```
caller(start=1)    -> Array or nil
```

- ```
caller(start=1)    -> array or nil
```
- Returns the current execution stack—an array containing strings
  in
- the form <em>file:line</em>'' or file:line: in
  @@ -1544,7 +1544,7 @@ rb_catch_obj(VALUE tag, VALUE (*func)(), VALUE
  data)

Returns +nil+ if start is greater than or equal to the size of

Returns +nil+ if start is greater than the size of

current execution stack.

def a(skip)

@@ -1556,11 +1556,12 @@ rb_catch_obj(VALUE tag, VALUE (*func)(), VALUE
data)

def c(skip)

b(skip)

end

c(0) #=> ["prog:2:in `a'", "prog:5:in `b'", "prog:8:in `c'",

“prog:10”]

c(1) #=> ["prog:5:in `b'", "prog:8:in `c'", "prog:11"]

c(2) #=> ["prog:8:in `c'", "prog:12"]

c(3) #=> ["prog:13"]

c(4) #=> nil

c(0) #=> ["prog:2:in `a'", "prog:5:in `b'", "prog:8:in `c'",

“prog:10:in `'”]

c(1) #=> ["prog:5:in `b'", "prog:8:in `c'", "prog:11:in

`'"]

c(2) #=> ["prog:8:in `c'", "prog:12:in `<main>'"]

c(3) #=> ["prog:13:in `<main>'"]

c(4) #=> []

c(5) #=> nil

*/

static VALUE