On Tue, Apr 26, 2016 at 04:52:22PM +0530, Pankaj Chaudhary wrote:
I have requirement to create own cookie based on input and wirte the that
cookie in header.
whenever i need that i can read from header and use it.
I confess that I do not understand what that requirement actually
is. There are headers in the request from the client to nginx; there
may be header-like things in whatever nginx does when communicating
with an upstream; there may be header-like things in the response from
that upstream; and there are headers in the response from nginx to the
client. And it is not clear to me what your module architecture is.
But that’s ok; I don’t have to understand it. You want to do some
things in an nginx module.
cookie = ngx_list_push(&r->headers_in.headers);
You are writing into the headers_in structure. Normally, that is what
came from the client, so I guess you must have a plan for why you are
(If I wanted to test “can I read from headers_in”, I would probably add
“MyHeader” to my curl request, and look for that in my code.)
ngx_str_t val = ngx_string(“cookie”);
clcf = ngx_http_get_module_main_conf(r, ngx_http_core_module);
key= ngx_hash_key_lc(val.data, val.len);
type = ngx_hash_find(&clcf->headers_in_hash, key, val.data, val.len);
As mentioned elsewhere, you are not reading from the headers_in
structure. So there’s a reasonable chance that what you wrote into one
structure will not be found in another one.
Also, you are treating the output of ngx_hash_find() as a ngx_str_t*.
The example code I see treats is as a ngx_http_header_t*.
Is that an important difference?
(As in: is that why you print the header name, but not the header
value? Possibly not, if the original request did not have any Cookie
header; but test rather than assume, if the documentation is not clear
if (type != NULL)
The example code I see has separate handling for “header is unknown or
is not hashed yet”, and “header is hashed but not cached yet”. You
seem to skip testing for the second possibility here.
test_val->lowcase_key = (u_char) “test_val”;
I’d also suggest that if you are not sure what value your content has,
use the simplest possible method to print it somewhere you can read
it. Usually, that means logging, since that should not have a complex
test_val->hash = ngx_crc32_long(test_val->lowcase_key, test_val->key.len);
Good luck with it,
Francis D. [email protected]