Forum: Ruby-core [Assigned] [PATCH] use khash for fstring and id_str tables

Eabad423977cfc6873b8f5df62b848a6?d=identicon&s=25 unknown (Guest)
on 2014-08-06 05:58
(Received via mailing list)
Issue #10096 has been updated by Hiroshi SHIBATA.

Status changed from Open to Assigned

Feature #10096: [PATCH] use khash for fstring and id_str tables

* Author: Eric Wong
* Status: Assigned
* Priority: Normal
* Assignee: Koichi Sasada
* Category: core
* Target version: current: 2.2.0
frozen_strings and global_symbols.id_str hashes are two of the bigger
hashes in Ruby.  They are needlessly ordered and incurs malloc overhead
in every st_table_entry.

Use an unordered open-addressing table which incurs no additional malloc
overhead besides the (larger) table itself.

Reduces "ruby -e exit" (w/RubyGems) by ~200K on eglibc malloc on
amd64 Debian stable due to having fewer allocations

global_symbols.str_id is left unchanged (for now) because it is used for
Symbol.all_symbols where ordering is expected

This introduces no user-visible changes or incompatibility
(unless I added a bug :x).

I chose khash because it is flexible and has (IMHO) a good API.
The API should also be familiar to mruby hackers, as mruby uses
a version of khash.

Future changes:

* covert smaller internal hashes where ordering is not exposed to Ruby
* (hopefully) other hashes (methods/constants/ivars) hashes [Feature

(Note: tried a few times in lynx with 503 errors, never had this problem
in lynx, trying clunky browser now)

khash.patch (35.5 KB)
This topic is locked and can not be replied to.