Forum: Ruby-core [Closed] Net::HTTPGenericRequest sets host even if it was set before by user

9361878d459f1709feec780518946ee5?d=identicon&s=25 unknown (Guest)
on 2014-08-05 21:11
(Received via mailing list)
Issue #10054 has been updated by Yui NARUSE.

Status changed from Feedback to Closed
% Done changed from 0 to 100

Applied in changeset r47077.

----------
* lib/net/http/generic_request.rb (Net::HTTP::GenericRequest#exec):
  handle req['host'] in update_uri.

* lib/net/http/generic_request.rb
  (Net::HTTP::GenericRequest#update_uri):
  use req['host'] if it is explicitly set. Even if URI is given,
  it is already used for the initial value of req['host'].
  Therefore overwritten value should be respected. [Bug #10054]

----------------------------------------
Bug #10054: Net::HTTPGenericRequest sets host even if it was set before
by user
https://bugs.ruby-lang.org/issues/10054#change-48203

* Author: Dmitriy Semenyuk
* Status: Closed
* Priority: Normal
* Assignee:
* Category: lib
* Target version:
* ruby -v: ruby 2.1.2p95 (2014-05-08 revision 45877) [x86_64-darwin13.0]
* Backport: 2.0.0: UNKNOWN, 2.1: UNKNOWN
----------------------------------------
~~~
# there is SSH tunnel that forwards 127.0.0.1:9293 to google.com:80
request = Net::HTTP::Post.new(URI("http://127.0.0.1:9293")).tap do |req|
  req.form_data = {q: "ruby"}
  req["Host"] = "google.com"
end
~~~

This code ignores host that was already set (it uses "#{host}:#{uri}"):

~~~
Net::HTTP.start(uri.hostname, uri.port) { |http| http.request(request) }
~~~

I encountered this bug when tried to connect to remote server using SSH
tunnel (/etc/hosts isn't available to edit).

Resolution:

https://bugs.ruby-lang.org/projects/ruby-trunk/rep...
line 119

~~~
def exec(sock, ver, path)   #:nodoc: internal use only
-    if @uri
+    if @uri && !self['host']
      if @uri.port == @uri.default_port
~~~
This topic is locked and can not be replied to.