Hi, What is the simplest way to validate a positive integer? validates_numericality_of :foo, :integer_only => true how do I add the positive part? Do I need another validation statement for pattern matching or do I have to write a validate() funciton for my model? Thanks, Peter
on 2006-01-19 21:07
on 2006-01-23 22:52
on 2006-01-23 23:50
On 1/23/06, Peter Michaux <email@example.com> wrote: > > for pattern matching or do I have to write a validate() funciton for > > my model? > > I'd go with this, personally: def validate unless foo_before_type_cast.to_s =~ /^[+]?\d+$/ errors.add("foo", "is not a valid number") end end 500 and +500 are valid, -500, -500.00, 400.12, etc, are not.
on 2006-01-23 23:56
Peter Michaux wrote: >> for pattern matching or do I have to write a validate() funciton for >> my model? Write your own function, I reckon.
on 2006-01-24 03:34
I hacked together a plugin to add a few parameters to validates_numericality_of based on your needs and my laziness for explicit checks. >From the README: Adds the following parameters: (plus the messages generated as an error) :gt => ## "must be greater than ##" :gte => ## "must be greater than or equal to ##" :eq => ## "must be equal to ##" :lt => ## "must be less than ##" :lte => ## "must be less than or equal to ##" :odd => ## "must be an odd number" :even => ## "must be an even number" :within => ##..## "must be within ## and ##" Usage: (in your case) validates_numericality_of :foo, :integer_only => true, :gt => 0 validates_numericality_of :age, :integer_only => true, :within => 13..100 If RoR team would like to integrate into Rails, have at it. I don't do well with rejection, so I won't offer it as a patch unless requested. Download it at: http://www.umesd.com/better_validates_numericality_of.zip I'll get it downloadable via script/plugin in due time. Gotta write a few unit tests first. Enjoy, Bob Silva
on 2006-01-26 03:28
Hi Bob, Thanks for the plugin. I think this should be included in rails as these are some very standard things to check. Peter
on 2006-01-26 03:40
After speaking with a buddy of mine also doing Rails, I need to make some modifications. It shouldn't have the :within since this can already be accomplished with validates_inclusion_of. As far as including in Rails, it depends what their definition of numericality is. With the current function name, it's not appropriate to have these extra checks in them and they really aren't critical, just saves some code to validate your input. But my second plugin, once I polish it off should definitely be included, but you'll have to wait for that one :) Bob Silva http://www.railtie.net/