Forum: Ruby-dev [ruby-trunk - misc #10032] Matrix classについて

0e610136db92027148906c92d57fdb36?d=identicon&s=25 unknown (Guest)
on 2014-07-18 12:36
(Received via mailing list)
Issue #10032 has been updated by Marc-Andre Lafortune.


gogo tanaka wrote:
> I think only Mr. Marc-Andre Lafortune can review my PR, and this is why it take
time to review.

I find it ironic that you feel it took me much time to review your
patch, when it took you the same time to make the needed changes. Also,
please feel free to "ping" me about issues I might have forgotten about,
either by updating the issue or by emailing me directly. Note that I
responded a couple of days after zzak did just that.

Finally, my personal goal is that PRs are dealt as early as convenient,
but definitely before a major release. Please realize that there is no
real way to accelerate this cycle for new features.

> I can find some codes only Mr. Marc-Andre Lafortune maintain,
> and it's kind of complicated for commiter who is not familiar with Linear
algebra.

I don't understand your comment. I certainly hope that any committer to
the Matrix library has some familiarity with linear algebra, this is
what the library deals with!

>Like that
https://github.com/ruby/ruby/blob/trunk/lib/matrix....

The eigenvalue decomposition code is indeed intricate, because it was
adapted directly from http://math.nist.gov/javanumerics/jama/
You will find the same method names and the same code, the same method
and variable names, etc...


----------------------------------------
misc #10032: Matrix classについて
https://bugs.ruby-lang.org/issues/10032#change-47860

* Author: gogo tanaka
* Status: Open
* Priority: Normal
* Assignee:
* Category: lib
* Target version:
----------------------------------------
こんにちは. 突然のご連絡失礼します.

もしこちらでお伺いするには不適切な内容であれば、お叱りと共にその旨をお伝え頂ければなと思います.

* 以下本文

Matrixクラスの貧弱さに憂いてGithub上からシコシコとPRを投げているのですが、

https://github.com/ruby/ruby/pull/594

こちらのPRなど最初のレビューを頂くまでに一ヶ月半を要しました. 問題だと感じました.

こちらは単純にGithubの扱われ方の問題なのか、

(だとしたら、Githubの使われ方を見直すべきだと思います)

それとも担当者が不足しているのか、

(だとしたら、僕にもっと権限を下さい.
↓ 今まで投げたPRです.
https://github.com/ruby/ruby/pulls/gogotanaka?dire...
)

またRubyの標準クラスであるMatrixクラスがなぜ今までこんな中途半端な状態で野さばってきたのか疑問です.

Gemに切り出す方が良いのではないかとも思っております.

ご回答のほどよろしくお願い致します.
This topic is locked and can not be replied to.