Forum: Ruby-core DateTime.strptime() doesn't work correctly for '%s %z'

1bb1c1a41b92d9f18e2890c3f6d33970?d=identicon&s=25 unknown (Guest)
on 2014-05-04 11:04
(Received via mailing list)
Issue #9794 has been updated by Felipe Contreras.

Nobuyoshi Nakada wrote:
> It doesn't seem there is absolute reason that you have to use `Time.strptime`.

Why wouldn't I? It does **exactly** what I want:

    Time.strptime('0 +0100', '%s %z').strftime('%s %z')
    => "0 +0100"

See? The problem is not Time, the problem is DateTime.

What "absolute" reason could there be for one doing the right thing, and
the other one not?

Bug #9794: DateTime.strptime() doesn't work correctly for '%s %z'

* Author: Felipe Contreras
* Status: Rejected
* Priority: Low
* Assignee: tadayoshi funaba
* Category: ext
* Target version:
* ruby -v: 2.1.1p76
* Backport: 2.0.0: UNKNOWN, 2.1: UNKNOWN
Time.strptime() works correctly:

    Time.strptime('0 +0100', '%s %z').strftime('%s %z')
    => "0 +0100"

But DateTime.strptime() doesn't:

    DateTime.strptime('0 +0100', '%s %z').strftime('%s %z')
    => "0 +0000"

In Rubinious it does work correctly:

    DateTime.strptime('0 +0100', '%s %z').strftime('%s %z')
    => "0 +0100"

This make the RubySL date space fail:

    DateTime#strptime parses seconds and timezone correctly FAILED
    Expected "1970-01-01T00:00:00+00:00"
     to equal "1970-01-01T01:00:00+01:00"

In addition, both C and perl preserver the offset correctly when doing
'%s %z'.

So it's very clear DateTime.strptime() has to be fixed.

Patch attached.

0001-datetime-fix-strptime-s-z.patch (1.94 KB)
This topic is locked and can not be replied to.