Forum: Ruby-core [ruby-trunk - Feature #9048][Open] Remove legacy ±(binary) special cases.

0e610136db92027148906c92d57fdb36?d=identicon&s=25 marcandre (Marc-Andre Lafortune) (Guest)
on 2013-10-23 17:31
(Received via mailing list)
Issue #9048 has been reported by marcandre (Marc-Andre Lafortune).

----------------------------------------
Feature #9048: Remove legacy ±(binary) special cases.
https://bugs.ruby-lang.org/issues/9048

Author: marcandre (Marc-Andre Lafortune)
Status: Open
Priority: Low
Assignee:
Category: core
Target version:


Is there any reason not to get rid of the following special cases?

    '+(binary)'.to_sym # => :+ when expected :"+(binary)"

The following patch didn't reveal any failure in make test:

diff --git a/parse.y b/parse.y
index 76fc9e7..6550235 100644
--- a/parse.y
+++ b/parse.y
@@ -10045,8 +10045,6 @@ static const struct {
 } op_tbl[] = {
     {tDOT2,    ".."},
     {tDOT3,    "..."},
-    {'+',      "+(binary)"},
-    {'-',      "-(binary)"},
     {tPOW,     "**"},
     {tDSTAR,   "**"},
     {tUPLUS,   "+@"},
diff --git a/test/ruby/test_m17n.rb b/test/ruby/test_m17n.rb
index 7c37c8a..3ea346f 100644
--- a/test/ruby/test_m17n.rb
+++ b/test/ruby/test_m17n.rb
@@ -1230,7 +1230,7 @@ class TestM17N < Test::Unit::TestCase

   def test_symbol_op
     ops = %w"
-      .. ... + - +(binary) -(binary) * / % ** +@ -@ | ^ & ! <=> > >= <
<= ==
+      .. ... + - * / % ** +@ -@ | ^ & ! <=> > >= < <= ==
       === != =~ !~ ~ ! [] []= << >> :: `
     "
     ops.each do |op|
0ec4920185b657a03edf01fff96b4e9b?d=identicon&s=25 matz (Yukihiro Matsumoto) (Guest)
on 2013-10-24 04:22
(Received via mailing list)
Issue #9048 has been updated by matz (Yukihiro Matsumoto).

Status changed from Open to Assigned
Assignee set to marcandre (Marc-Andre Lafortune)

I agree.

Matz.

----------------------------------------
Feature #9048: Remove legacy ±(binary) special cases.
https://bugs.ruby-lang.org/issues/9048#change-42587

Author: marcandre (Marc-Andre Lafortune)
Status: Assigned
Priority: Low
Assignee: marcandre (Marc-Andre Lafortune)
Category: core
Target version:


Is there any reason not to get rid of the following special cases?

    '+(binary)'.to_sym # => :+ when expected :"+(binary)"

The following patch didn't reveal any failure in make test:

diff --git a/parse.y b/parse.y
index 76fc9e7..6550235 100644
--- a/parse.y
+++ b/parse.y
@@ -10045,8 +10045,6 @@ static const struct {
 } op_tbl[] = {
     {tDOT2,    ".."},
     {tDOT3,    "..."},
-    {'+',      "+(binary)"},
-    {'-',      "-(binary)"},
     {tPOW,     "**"},
     {tDSTAR,   "**"},
     {tUPLUS,   "+@"},
diff --git a/test/ruby/test_m17n.rb b/test/ruby/test_m17n.rb
index 7c37c8a..3ea346f 100644
--- a/test/ruby/test_m17n.rb
+++ b/test/ruby/test_m17n.rb
@@ -1230,7 +1230,7 @@ class TestM17N < Test::Unit::TestCase

   def test_symbol_op
     ops = %w"
-      .. ... + - +(binary) -(binary) * / % ** +@ -@ | ^ & ! <=> > >= <
<= ==
+      .. ... + - * / % ** +@ -@ | ^ & ! <=> > >= < <= ==
       === != =~ !~ ~ ! [] []= << >> :: `
     "
     ops.each do |op|
5cf8f058a4c094bb708174fb43e7a387?d=identicon&s=25 nagachika (Tomoyuki Chikanaga) (Guest)
on 2013-10-24 15:16
(Received via mailing list)
Issue #9048 has been updated by nagachika (Tomoyuki Chikanaga).

Backport set to 1.9.3: REQUIRED, 2.0.0: REQUIRED
ruby -v set to -


----------------------------------------
Bug #9048: Remove legacy ±(binary) special cases.
https://bugs.ruby-lang.org/issues/9048#change-42599

Author: marcandre (Marc-Andre Lafortune)
Status: Closed
Priority: Low
Assignee: marcandre (Marc-Andre Lafortune)
Category: core
Target version:
ruby -v: -
Backport: 1.9.3: REQUIRED, 2.0.0: REQUIRED


Is there any reason not to get rid of the following special cases?

    '+(binary)'.to_sym # => :+ when expected :"+(binary)"

The following patch didn't reveal any failure in make test:

diff --git a/parse.y b/parse.y
index 76fc9e7..6550235 100644
--- a/parse.y
+++ b/parse.y
@@ -10045,8 +10045,6 @@ static const struct {
 } op_tbl[] = {
     {tDOT2,    ".."},
     {tDOT3,    "..."},
-    {'+',      "+(binary)"},
-    {'-',      "-(binary)"},
     {tPOW,     "**"},
     {tDSTAR,   "**"},
     {tUPLUS,   "+@"},
diff --git a/test/ruby/test_m17n.rb b/test/ruby/test_m17n.rb
index 7c37c8a..3ea346f 100644
--- a/test/ruby/test_m17n.rb
+++ b/test/ruby/test_m17n.rb
@@ -1230,7 +1230,7 @@ class TestM17N < Test::Unit::TestCase

   def test_symbol_op
     ops = %w"
-      .. ... + - +(binary) -(binary) * / % ** +@ -@ | ^ & ! <=> > >= <
<= ==
+      .. ... + - * / % ** +@ -@ | ^ & ! <=> > >= < <= ==
       === != =~ !~ ~ ! [] []= << >> :: `
     "
     ops.each do |op|
5cf8f058a4c094bb708174fb43e7a387?d=identicon&s=25 nagachika (Tomoyuki Chikanaga) (Guest)
on 2013-10-24 16:00
(Received via mailing list)
Issue #9048 has been updated by nagachika (Tomoyuki Chikanaga).

Backport changed from 1.9.3: REQUIRED, 2.0.0: REQUIRED to 1.9.3:
REQUIRED, 2.0.0: DONE

r43413 is backported to ruby_2_0_0 branch at r43415.
----------------------------------------
Bug #9048: Remove legacy ±(binary) special cases.
https://bugs.ruby-lang.org/issues/9048#change-42601

Author: marcandre (Marc-Andre Lafortune)
Status: Closed
Priority: Low
Assignee: marcandre (Marc-Andre Lafortune)
Category: core
Target version:
ruby -v: -
Backport: 1.9.3: REQUIRED, 2.0.0: DONE


Is there any reason not to get rid of the following special cases?

    '+(binary)'.to_sym # => :+ when expected :"+(binary)"

The following patch didn't reveal any failure in make test:

diff --git a/parse.y b/parse.y
index 76fc9e7..6550235 100644
--- a/parse.y
+++ b/parse.y
@@ -10045,8 +10045,6 @@ static const struct {
 } op_tbl[] = {
     {tDOT2,    ".."},
     {tDOT3,    "..."},
-    {'+',      "+(binary)"},
-    {'-',      "-(binary)"},
     {tPOW,     "**"},
     {tDSTAR,   "**"},
     {tUPLUS,   "+@"},
diff --git a/test/ruby/test_m17n.rb b/test/ruby/test_m17n.rb
index 7c37c8a..3ea346f 100644
--- a/test/ruby/test_m17n.rb
+++ b/test/ruby/test_m17n.rb
@@ -1230,7 +1230,7 @@ class TestM17N < Test::Unit::TestCase

   def test_symbol_op
     ops = %w"
-      .. ... + - +(binary) -(binary) * / % ** +@ -@ | ^ & ! <=> > >= <
<= ==
+      .. ... + - * / % ** +@ -@ | ^ & ! <=> > >= < <= ==
       === != =~ !~ ~ ! [] []= << >> :: `
     "
     ops.each do |op|
8cbb39dadafaf2287a83a13ee4981ec9?d=identicon&s=25 usa (Usaku NAKAMURA) (Guest)
on 2013-10-31 16:06
(Received via mailing list)
Issue #9048 has been updated by usa (Usaku NAKAMURA).

Backport changed from 1.9.3: REQUIRED, 2.0.0: DONE to 1.9.3: DONE,
2.0.0: DONE

Backported to ruby_1_9_3 at r43493.
----------------------------------------
Bug #9048: Remove legacy ±(binary) special cases.
https://bugs.ruby-lang.org/issues/9048#change-42696

Author: marcandre (Marc-Andre Lafortune)
Status: Closed
Priority: Low
Assignee: marcandre (Marc-Andre Lafortune)
Category: core
Target version:
ruby -v: -
Backport: 1.9.3: DONE, 2.0.0: DONE


Is there any reason not to get rid of the following special cases?

    '+(binary)'.to_sym # => :+ when expected :"+(binary)"

The following patch didn't reveal any failure in make test:

diff --git a/parse.y b/parse.y
index 76fc9e7..6550235 100644
--- a/parse.y
+++ b/parse.y
@@ -10045,8 +10045,6 @@ static const struct {
 } op_tbl[] = {
     {tDOT2,    ".."},
     {tDOT3,    "..."},
-    {'+',      "+(binary)"},
-    {'-',      "-(binary)"},
     {tPOW,     "**"},
     {tDSTAR,   "**"},
     {tUPLUS,   "+@"},
diff --git a/test/ruby/test_m17n.rb b/test/ruby/test_m17n.rb
index 7c37c8a..3ea346f 100644
--- a/test/ruby/test_m17n.rb
+++ b/test/ruby/test_m17n.rb
@@ -1230,7 +1230,7 @@ class TestM17N < Test::Unit::TestCase

   def test_symbol_op
     ops = %w"
-      .. ... + - +(binary) -(binary) * / % ** +@ -@ | ^ & ! <=> > >= <
<= ==
+      .. ... + - * / % ** +@ -@ | ^ & ! <=> > >= < <= ==
       === != =~ !~ ~ ! [] []= << >> :: `
     "
     ops.each do |op|
This topic is locked and can not be replied to.