Forum: Ruby-dev [ruby-trunk - Bug #9046][Open] [PATCH] Inter-process locking for log rotation is required

Aef92c3acc29ad8543e04135687fc4f1?d=identicon&s=25 sonots (Naotoshi Seo) (Guest)
on 2013-10-23 08:44
(Received via mailing list)
Issue #9046 has been reported by sonots (Naotoshi Seo).

----------------------------------------
Bug #9046: [PATCH] Inter-process locking for log rotation is required
https://bugs.ruby-lang.org/issues/9046

Author: sonots (Naotoshi Seo)
Status: Open
Priority: Normal
Assignee:
Category: lib
Target version: current: 2.1.0
ruby -v: ruby 2.1.0dev (2013-10-20 trunk 43373) [x86_64-darwin12.2.1]
Backport: 1.9.3: UNKNOWN, 2.0.0: UNKNOWN


I sent a pull request on https://github.com/ruby/ruby/pull/428. Please
see details on it.
9d2f78236e45a335301ba1195026105d?d=identicon&s=25 shyouhei (Shyouhei Urabe) (Guest)
on 2013-10-23 08:50
(Received via mailing list)
Issue #9046 has been updated by shyouhei (Shyouhei Urabe).

Description updated


----------------------------------------
Bug #9046: [PATCH] Inter-process locking for log rotation is required
https://bugs.ruby-lang.org/issues/9046#change-42557

Author: sonots (Naotoshi Seo)
Status: Open
Priority: Normal
Assignee:
Category: lib
Target version: current: 2.1.0
ruby -v: ruby 2.1.0dev (2013-10-20 trunk 43373) [x86_64-darwin12.2.1]
Backport: 1.9.3: UNKNOWN, 2.0.0: UNKNOWN


I sent a pull request on https://github.com/ruby/ruby/pull/428 . Please
see details on it.
9361878d459f1709feec780518946ee5?d=identicon&s=25 naruse (Yui NARUSE) (Guest)
on 2013-10-23 10:12
(Received via mailing list)
Issue #9046 has been updated by naruse (Yui NARUSE).


The point "current implementation is wrong on multi-process environment"
sounds reasonable and need to fix.

I commented some implementation points to the pull request.
----------------------------------------
Bug #9046: [PATCH] Inter-process locking for log rotation is required
https://bugs.ruby-lang.org/issues/9046#change-42560

Author: sonots (Naotoshi Seo)
Status: Open
Priority: Normal
Assignee:
Category: lib
Target version: current: 2.1.0
ruby -v: ruby 2.1.0dev (2013-10-20 trunk 43373) [x86_64-darwin12.2.1]
Backport: 1.9.3: UNKNOWN, 2.0.0: UNKNOWN


I sent a pull request on https://github.com/ruby/ruby/pull/428 . Please
see details on it.
F1d6cc2b735bfd82c8773172da2aeab9?d=identicon&s=25 Nobuyoshi Nakada (nobu)
on 2013-11-02 05:47
(Received via mailing list)
Issue #9046 has been updated by nobu (Nobuyoshi Nakada).

Status changed from Closed to Open
Priority changed from Normal to High
% Done changed from 100 to 0

It broke on Windows.

* don't use fork.
* don't assume that open file can be removed or renamed.

I'll try to fix or revert it.
----------------------------------------
Bug #9046: [PATCH] Inter-process locking for log rotation is required
https://bugs.ruby-lang.org/issues/9046#change-42727

Author: sonots (Naotoshi Seo)
Status: Open
Priority: High
Assignee:
Category: lib
Target version: current: 2.1.0
ruby -v: ruby 2.1.0dev (2013-10-20 trunk 43373) [x86_64-darwin12.2.1]
Backport: 1.9.3: UNKNOWN, 2.0.0: UNKNOWN


I sent a pull request on https://github.com/ruby/ruby/pull/428 . Please
see details on it.
This topic is locked and can not be replied to.