Forum: Ruby-core [ruby-trunk - Bug #8685][Open] Problems of the example of REXM::Attribute#namespace

C4e88907313843cf07f6d85ba8162120?d=identicon&s=25 ohai (Ippei Obayashi) (Guest)
on 2013-07-25 18:36
(Received via mailing list)
Issue #8685 has been reported by ohai (Ippei Obayashi).

----------------------------------------
Bug #8685: Problems of the example of REXM::Attribute#namespace
https://bugs.ruby-lang.org/issues/8685

Author: ohai (Ippei Obayashi)
Status: Open
Priority: Normal
Assignee: zzak (Zachary Scott)
Category: doc
Target version:
ruby -v: ruby 2.1.0dev (2013-07-25 trunk 42169) [x86_64-linux]
Backport: 1.9.3: UNKNOWN, 2.0.0: UNKNOWN


The exmaple of the comment document of REXML::Attribute#namespace has
some problems.
  * An old style hash literal is used.
  * The example really does not use EXML::Attribute#namespace
A patch to fix the example is attached to this ticket.
054b5f6b8afdd5f6190bad08e46cd782?d=identicon&s=25 zzak (Zachary Scott) (Guest)
on 2013-07-25 19:10
(Received via mailing list)
Issue #8685 has been updated by zzak (Zachary Scott).


@ohai Thank you! It seems you removed an example for #add_attributes

Why was this removed?
----------------------------------------
Bug #8685: Problems of the example of REXM::Attribute#namespace
https://bugs.ruby-lang.org/issues/8685#change-40667

Author: ohai (Ippei Obayashi)
Status: Open
Priority: Normal
Assignee: zzak (Zachary Scott)
Category: doc
Target version:
ruby -v: ruby 2.1.0dev (2013-07-25 trunk 42169) [x86_64-linux]
Backport: 1.9.3: UNKNOWN, 2.0.0: UNKNOWN


The exmaple of the comment document of REXML::Attribute#namespace has
some problems.
  * An old style hash literal is used.
  * The example really does not use EXML::Attribute#namespace
A patch to fix the example is attached to this ticket.
054b5f6b8afdd5f6190bad08e46cd782?d=identicon&s=25 zzak (Zachary Scott) (Guest)
on 2013-07-25 19:10
(Received via mailing list)
Issue #8685 has been updated by zzak (Zachary Scott).

Status changed from Open to Assigned


----------------------------------------
Bug #8685: Problems of the example of REXM::Attribute#namespace
https://bugs.ruby-lang.org/issues/8685#change-40668

Author: ohai (Ippei Obayashi)
Status: Assigned
Priority: Normal
Assignee: zzak (Zachary Scott)
Category: doc
Target version:
ruby -v: ruby 2.1.0dev (2013-07-25 trunk 42169) [x86_64-linux]
Backport: 1.9.3: UNKNOWN, 2.0.0: UNKNOWN


The exmaple of the comment document of REXML::Attribute#namespace has
some problems.
  * An old style hash literal is used.
  * The example really does not use EXML::Attribute#namespace
A patch to fix the example is attached to this ticket.
C4e88907313843cf07f6d85ba8162120?d=identicon&s=25 ohai (Ippei Obayashi) (Guest)
on 2013-07-28 13:07
(Received via mailing list)
Issue #8685 has been updated by ohai (Ippei Obayashi).


zzak (Zachary Scott) wrote:
> @ohai Thank you! It seems you removed an example for #add_attributes
>
> Why was this removed?
This is because
  * the example is a part the document of REXM::Attribute#namespace, not
a part of REXML::Element#add_attributes
  * REXML::Element#add_namespace is a better way to add a new namespace
rather than add_attribute

----------------------------------------
Bug #8685: Problems of the example of REXM::Attribute#namespace
https://bugs.ruby-lang.org/issues/8685#change-40734

Author: ohai (Ippei Obayashi)
Status: Assigned
Priority: Normal
Assignee: zzak (Zachary Scott)
Category: doc
Target version:
ruby -v: ruby 2.1.0dev (2013-07-25 trunk 42169) [x86_64-linux]
Backport: 1.9.3: UNKNOWN, 2.0.0: UNKNOWN


The exmaple of the comment document of REXML::Attribute#namespace has
some problems.
  * An old style hash literal is used.
  * The example really does not use EXML::Attribute#namespace
A patch to fix the example is attached to this ticket.
This topic is locked and can not be replied to.