Forum: IronRuby Pull request #31 - fix workitem 6345, implemented IO#binread

B3068fb9bae93b2889ffc73feb1b3195?d=identicon&s=25 Enrico Sada (Guest)
on 2011-08-08 01:42
(Received via mailing list)
The pull request #31 ( https://github.com/IronLanguages/main/pull/31 )
is for resolve workitem 6345 (
http://ironruby.codeplex.com/workitem/6345 ).

Implemented IO#binread with rubyspec (sent also to rubyspec/rubyspec).

This anyway is not enough for fix rdoc, needed for gem install.

C:\repo\IronLanguages>igem install rake
Successfully installed rake-0.9.2
1 gem installed
Installing ri documentation for rake-0.9.2...
C:/repo/IronLanguages/Languages/Ruby/StdLib/ruby/1.9.1/rdoc/text.rb:12:in
`expan
d_tabs': parsing "^(.{8}*?)([\x00-?-[\\t\\r\\n]]{0,7})\\t" - Nested
quantifier *
. (SyntaxError)
        from
C:/repo/IronLanguages/Languages/Ruby/StdLib/ruby/1.9.1/rdoc/text.rb
:9:in `lines'
        from
C:/repo/IronLanguages/Languages/Ruby/StdLib/ruby/1.9.1/rdoc/text.rb
:9:in `expand_tabs'
        from
C:/repo/IronLanguages/Languages/Ruby/StdLib/ruby/1.9.1/rdoc/text.rb
:60:in `normalize_comment'
        from
C:/repo/IronLanguages/Languages/Ruby/StdLib/ruby/1.9.1/rdoc/code_ob
ject.rb:97:in `comment='
        from
C:/repo/IronLanguages/Languages/Ruby/StdLib/ruby/1.9.1/rdoc/rdoc.rb
:278:in `parse_file'
        from
C:/repo/IronLanguages/Languages/Ruby/StdLib/ruby/1.9.1/rdoc/rdoc.rb
:322:in `parse_files'

i think the problem is  .{8}*? , (like
http://stackoverflow.com/questions/210206/what-is-...
) i will check it later, probably an rdoc modify is needed, dont know
how to fix it ironruby side.
Cb51033949ffccd982ae32c9f890f25a?d=identicon&s=25 Tomas Matousek (Guest)
on 2011-08-08 06:37
(Received via mailing list)
I can take a look at fixing the regex issue perhaps next weekend.

Tomas
Cb51033949ffccd982ae32c9f890f25a?d=identicon&s=25 Tomas Matousek (Guest)
on 2011-08-14 22:16
(Received via mailing list)
Regex should be fixed now.
This topic is locked and can not be replied to.