Forum: IronRuby Code Review: ProGenFix

Announcement (2017-05-07): www.ruby-forum.com is now read-only since I unfortunately do not have the time to support and maintain the forum any more. Please see rubyonrails.org/community and ruby-lang.org/en/community for other Rails- und Ruby-related community platforms.
Cb51033949ffccd982ae32c9f890f25a?d=identicon&s=25 Tomas Matousek (Guest)
on 2009-06-06 22:02
(Received via mailing list)
Attachment: ProGenFix.diff (20 KB)
tfpt review "/shelveset:ProGenFix;REDMOND\tomat"

DLR, Python, Ruby.

Fixes Ruby calls to protected generic methods.
Adds CompilerHelpers.IsProtected() as an alias for IsFamily ||
IsFamilyOrAssembly.

Tomas
F983f0c990cba2fe743ef62a975ec99c?d=identicon&s=25 Curt Hagenlocher (Guest)
on 2009-06-06 23:17
(Received via mailing list)
Changes look good overall. I'm not sure that Type.IsProtected() is an
intuitive name; maybe Type.IsNested() would be clearer?
Cb51033949ffccd982ae32c9f890f25a?d=identicon&s=25 Tomas Matousek (Guest)
on 2009-06-07 01:02
(Received via mailing list)
You mean IsNestedProteced()? "Nested" feels superfluous since only
nested types could be protected.

Tomas
F983f0c990cba2fe743ef62a975ec99c?d=identicon&s=25 Curt Hagenlocher (Guest)
on 2009-06-07 01:26
(Received via mailing list)
Ah, I see. Still, something strikes me as odd about the name, but I
don't feel strongly about it.
This topic is locked and can not be replied to.