Forum: Ruby Question on redefining the File.join mechanism

Announcement (2017-05-07): www.ruby-forum.com is now read-only since I unfortunately do not have the time to support and maintain the forum any more. Please see rubyonrails.org/community and ruby-lang.org/en/community for other Rails- und Ruby-related community platforms.
31fdda5f38fc6df4e193cfb7445ddc5a?d=identicon&s=25 RichardOnRails (Guest)
on 2009-05-12 16:00
(Received via mailing list)
I'm running Ruby over WindowsXP-Pro/SP2.  So I wanted File.join to use
backslash.

I tried:

class WFile < File
  def join(arg1, arg2)
    super.join(arg1, arg2).gsub(/\//, '\\')
  end
end

but WFile.join(s1,s2) didn't work.  My question is why?

BTW,  I don't want to start or enter into a debate about the wisdom
nor aesthetics of this approach.

Also,  I got the File.wjoin to work (using the code below), so I'm
happy.  I just want to learn why my first idea is flawed.

class File # Join with a backslash rather than a forward slash
  def File.wjoin(arg1, arg2)
    join(arg1, arg2).gsub(/\//, '\\')
  end
end

Thanks in Advance,
Richard
4828d528e2e46f7c8160c336eb332836?d=identicon&s=25 Robert Heiler (shevegen)
on 2009-05-12 16:10
> I just want to learn why my first idea is flawed.

I believe one culprit is probably
  super.join

In fact, I never saw super.join, only super() on something.

Where did you see super.something ?
E0d864d9677f3c1482a20152b7cac0e2?d=identicon&s=25 Robert Klemme (Guest)
on 2009-05-12 16:35
(Received via mailing list)
2009/5/12 RichardOnRails <RichardDummyMailbox58407@uscomputergurus.com>:
> I'm running Ruby over WindowsXP-Pro/SP2.  So I wanted File.join to use
> backslash.
>
> I tried:
>
> class WFile < File
>  def join(arg1, arg2)
>    super.join(arg1, arg2).gsub(/\//, '\\')

That line should look like one of these variants:

super.gsub(/\//, '\\')
super(arg1, arg2).gsub(/\//, '\\')

However, since join is a class method you would want to define it as
class method in WFile.

irb(main):001:0> class WFile < File
irb(main):002:1> def self.join(*a) super.gsub(%r{/}, '\\\\') end
irb(main):003:1> end
=> nil
irb(main):004:0> WFile.join "foo", "bar", "baz"
=> "foo\\bar\\baz"
irb(main):005:0>

>
> class File # Join with a backslash rather than a forward slash
>  def File.wjoin(arg1, arg2)
>    join(arg1, arg2).gsub(/\//, '\\')
>  end
> end

Another however: since you are defining a single method only the
question is whether it warrants a comlete class.  Why not just define
wjoin in class File or simply override File's definition, e.g.

def File.join(*a)
  a.join '\\'
end

Kind regards

robert
31fdda5f38fc6df4e193cfb7445ddc5a?d=identicon&s=25 RichardOnRails (Guest)
on 2009-05-13 07:50
(Received via mailing list)
> In fact, I never saw super.join, only super() on something.
>
> Where did you see super.something ?

Must have been in a dream :-)  Please see my solution in my reply to
Robert.

Thanks for your response,
Richard
31fdda5f38fc6df4e193cfb7445ddc5a?d=identicon&s=25 RichardOnRails (Guest)
on 2009-05-13 08:00
(Received via mailing list)
On May 12, 10:34 am, Robert Klemme <shortcut...@googlemail.com> wrote:
>
> irb(main):003:1> end
> > but WFile.join(s1,s2) didn't work.  My question is why?
> >  end
> Kind regards
>
> robert
>
> --
> remember.guy do |as, often| as.you_can - without endhttp://blog.rubybestpractices.com/

Hi Robert,

Thanks to Marc in the previous post and to you,  my head cleared and
following is the solution I sought, which is a style that suits my
aesthetics :-)  :

class WFile
  def WFile.join(arg1, arg2)
    File.join(arg1, arg2).gsub(/\//, '\\')
  end
end

puts WFile.join('foo', 'bar') # => foo\bar

Ya gotta love comp.lang.ruby.

Best wishes,
Richard
31fdda5f38fc6df4e193cfb7445ddc5a?d=identicon&s=25 RichardOnRails (Guest)
on 2009-05-13 08:35
(Received via mailing list)
On May 12, 10:34 am, Robert Klemme <shortcut...@googlemail.com> wrote:
>
> irb(main):003:1> end
> > but WFile.join(s1,s2) didn't work.  My question is why?
> >  end
> Kind regards
>
> robert
>
> --
> remember.guy do |as, often| as.you_can - without endhttp://blog.rubybestpractices.com/

Hi, again, Robert,

Just a little follow-up.  When I first read your response,  I grabbed
your "class method" observation and ran with it.  I saw your
additional 3-liner,  but didn't understand it at first glance.

Now I see that you've reduced the matter to Array#join,  so I could
simple write:

['foo', 'bar'].join '\\' # => foo\bar,

but wrapping in a 3-liner like yours probably simplifies invocation.
I'll think about it some more.  Your 3-liner looks like one more "best
practice",  which site I just visited.

Thanks for education in Ruby elegance.

Best wishes,
Richard
E0d864d9677f3c1482a20152b7cac0e2?d=identicon&s=25 Robert Klemme (Guest)
on 2009-05-13 21:40
(Received via mailing list)
On 13.05.2009 08:31, RichardOnRails wrote:
> Now I see that you've reduced the matter to Array#join,  so I could
> simple write:
>
> ['foo', 'bar'].join '\\' # => foo\bar,

Exactly.

> but wrapping in a 3-liner like yours probably simplifies invocation.
> I'll think about it some more.  Your 3-liner looks like one more "best
> practice",  which site I just visited.
>
> Thanks for education in Ruby elegance.

You're welcome!  Just another remark: it's been a while that I used the
Windows version of Ruby (I work mostly on cygwin and Linux) but as far
as I remember if you need those file names only internally (i.e. in the
Ruby program) then the regular File.join will do as you can use forward
and backward slashes.

Kind regards

  robert
31fdda5f38fc6df4e193cfb7445ddc5a?d=identicon&s=25 RichardOnRails (Guest)
on 2009-05-14 18:05
(Received via mailing list)
> ... then the regular File.join will do as you can use
> forward and backward slashes.

That has been my experience,  but I don't like relying on that and
finally decided to fix it to my liking.

Thanks again and best wishes,
Richard
This topic is locked and can not be replied to.