Forum: Ruby my logroll code, please critique

Announcement (2017-05-07): www.ruby-forum.com is now read-only since I unfortunately do not have the time to support and maintain the forum any more. Please see rubyonrails.org/community and ruby-lang.org/en/community for other Rails- und Ruby-related community platforms.
F6a3dfee23741adec521eff5fa003aa0?d=identicon&s=25 Derek Smith (derekbsmith)
on 2009-05-05 03:01
My goal is to keep 10 files each at 100Mb. Please critique and suggest
any corrections I need to make.  Thank you!



#!/usr/bin/ruby -w -W 2

require 'ftools'
require 'fileutils'

=begin
#-----------------------------
File::LOCK_SH     # shared lock (for reading)
File::LOCK_EX     # exclusive lock (for writing)
File::LOCK_NB     # non-blocking request
File::LOCK_UN     # free lock
#-----------------------------
=end


###-- 10 files at 100Mb before rolling begins ---##

FSIZE = 104860000

Dir.chdir("/cygdrive/c/temp/log") \
    or raise StandardError, "Change dir failed to ~aevrlog!"

unless File.exists?("/cygdrive/c/temp/log/zipped")
    File.makedirs("zipped") \
    or raise StandardError, "Make dir failed to ~aevrlog/zipped!"
end

array1 = Dir.glob("dev*.log")
array2 = Dir.glob("mon*.log")
array3 = Dir.glob("fer*_se*.out")
array4 = Dir.glob("fer*_se*.log")
array5 = Dir.glob("fer*_in*.log")

if (array1.length >= 1)
    array1.each { |file|

    if (File.size(file) > FSIZE)
        `/usr/bin/gzip "#{file}"`
        FileUtils.mv("#{file}.gz","/cygdrive/c/temp/log/zipped")
        FileUtils.touch("development.log")
    end
    }
end

Dir.chdir("/cygdrive/c/temp/log/zipped") \
    or raise StandardError, "Change dir failed to ~aevrlog!"

array1_1 = Dir["/cygdrive/c/temp/log/zipped/dev*.gz"]

    if (array1_1.length >= 1)
        if File.exists?("development.log.11.gz")
            FileUtils.rm_r
Dir.glob("/cygdrive/c/temp/log/zipped/dev*11.gz")
        end
        if File.exists?("development.log.10.gz")
            File.copy("development.log.10.gz", "development.log.11.gz")
        end
        if File.exists?("development.log.8.gz")
            File.copy("development.log.8.gz", "development.log.9.gz")
        end
        if File.exists?("development.log.7.gz")
            File.copy("development.log.7.gz", "development.log.8.gz")
        end
        if File.exists?("development.log.6.gz")
            File.copy("development.log.6.gz", "development.log.7.gz")
        end
        if File.exists?("development.log.5.gz")
            File.copy("development.log.5.gz", "development.log.6.gz")
        end
        if File.exists?("development.log.4.gz")
            File.copy("development.log.4.gz", "development.log.5.gz")
        end
        if File.exists?("development.log.3.gz")
            File.copy("development.log.3.gz", "development.log.4.gz")
        end
        if File.exists?("development.log.2.gz")
            File.copy("development.log.2.gz", "development.log.3.gz")
        end
        if File.exists?("development.log.1.gz")
            File.copy("development.log.1.gz", "development.log.2.gz")
        end
        if File.exists?("development.log.gz")
            File.copy("development.log.gz", "development.log.1.gz")
        end
    end
Fbb4d027695dfdf76bf448b15d7e306a?d=identicon&s=25 matt neuburg (Guest)
on 2009-05-05 03:56
(Received via mailing list)
Derek Smith <derekbellnersmith@yahoo.com> wrote:

>         if File.exists?("development.log.10.gz")
>             File.copy("development.log.10.gz", "development.log.11.gz")
>         end
>         if File.exists?("development.log.8.gz")
>             File.copy("development.log.8.gz", "development.log.9.gz")
>         end
>         # etc, over and over and over and over

You forgot log.9, and the very fact that this can happen, along with the
patterned repetition here, would appear to be a Bad Smell (as in
"Refactoring"). Why 30 hard-coded lines when a 5-line loop will do? m.
E0d864d9677f3c1482a20152b7cac0e2?d=identicon&s=25 Robert Klemme (Guest)
on 2009-05-05 08:34
(Received via mailing list)
On 05.05.2009 03:52, matt neuburg wrote:
> You forgot log.9, and the very fact that this can happen, along with the
> patterned repetition here, would appear to be a Bad Smell (as in
> "Refactoring"). Why 30 hard-coded lines when a 5-line loop will do? m.

Another thing that struck me is the usage of File.copy.  File.rename
would be much more efficient plus it would not change the last
modification time of the file.

Kind regards

  robert
D15a45a973443d4562051eb675b60474?d=identicon&s=25 Tom Cloyd (Guest)
on 2009-05-05 10:55
(Received via mailing list)
Derek Smith wrote:
> =begin
>
> array1 = Dir.glob("dev*.log")
>         FileUtils.mv("#{file}.gz","/cygdrive/c/temp/log/zipped")
>     if (array1_1.length >= 1)
>         if File.exists?("development.log.7.gz")
>         end
>             File.copy("development.log.gz", "development.log.1.gz")
>         end
>     end
>
Derek, I'm interested in what your trying to do here, and in the
comments it's elicited. Could you share you revised code, when it's
ready (or backchannel it, if you wish). I could definitely USE this!

Tom
4d5b5dd4e263d780a5dfe7ac8b8ac98c?d=identicon&s=25 Tim Pease (Guest)
on 2009-05-05 17:13
(Received via mailing list)
On Tue, May 5, 2009 at 2:55 AM, Tom Cloyd <tomcloyd@comcast.net> wrote:
> backchannel it, if you wish). I could definitely USE this!
>

Take a look at the "logging" gem. The RollingFile appender will do
exactly this -- rolling files based on size or age. Moreover, it will
safely roll the files even if multiple processes are writing to the
same file.

rubyforge.org/projects/logging

Blessings,
TwP
F6a3dfee23741adec521eff5fa003aa0?d=identicon&s=25 Derek Smith (derekbsmith)
on 2009-05-06 00:44
Tim Pease wrote:
> On Tue, May 5, 2009 at 2:55 AM, Tom Cloyd <tomcloyd@comcast.net> wrote:
>> backchannel it, if you wish). I could definitely USE this!
>>
>
> Take a look at the "logging" gem. The RollingFile appender will do
> exactly this -- rolling files based on size or age. Moreover, it will
> safely roll the files even if multiple processes are writing to the
> same file.
>
> rubyforge.org/projects/logging
>
> Blessings,
> TwP

I did look into this gem, but the documentation was weak and I tried to
work it, but could not and failed so I wrote my own since I am new to
Ruby.  A good learning exp!....yucky Perl, ugly code is not for me!

Will anyone share good sample code for logging?
Thanks to all that replied, but Matt will you show me this loop you
referred to?


Thank you!
58479f76374a3ba3c69b9804163f39f4?d=identicon&s=25 Eric Hodel (Guest)
on 2009-05-06 00:59
(Received via mailing list)
On May 5, 2009, at 15:44, Derek Smith wrote:
>>
> Will anyone share good sample code for logging?
> Thanks to all that replied, but Matt will you show me this loop you
> referred to?

I use SyslogLogger (which adapts Syslog to a Logger API) and newsyslog
to rotate logs.
47b1910084592eb77a032bc7d8d1a84e?d=identicon&s=25 Joel VanderWerf (Guest)
on 2009-05-06 01:19
(Received via mailing list)
Derek Smith wrote:
> Will anyone share good sample code for logging?

There's the logger.rb in the ruby standard library (or did someone
mention that already?). It handles rotation, log levels, but perhaps not
multiprocess safety.
F6a3dfee23741adec521eff5fa003aa0?d=identicon&s=25 Derek Smith (derekbsmith)
on 2009-05-06 02:23
Joel VanderWerf wrote:
> Derek Smith wrote:
>> Will anyone share good sample code for logging?
>
> There's the logger.rb in the ruby standard library (or did someone
> mention that already?). It handles rotation, log levels, but perhaps not
> multiprocess safety.

Here is my updated code, but how do I look at the documentation from the
CLI for logger, logging or any gem?  For example, if I want to look at
Perl docs I use perldoc -f "builtin function" or perldoc -q "F.A.Q."
Finally, what about a central logging block for when at anytime 'raise
StandardError' is called, the script will log to one logfile.  Will
anyone suggest code or how to do this?


thank you!


#!/usr/bin/ruby -w -W 2

require 'ftools'
require 'fileutils'

=begin
#-----------------------------
File::LOCK_SH     # shared lock (for reading)
File::LOCK_EX     # exclusive lock (for writing)
File::LOCK_NB     # non-blocking request
File::LOCK_UN     # free lock
#-----------------------------
=end


###-- 10 files at 100Mb before rolling begins ---##

FSIZE = 104860000

Dir.chdir("/cygdrive/c/temp/log") \
    or raise StandardError, "Change dir failed to ~aevrlog!"

unless File.exists?("/cygdrive/c/temp/log/zipped")
    File.makedirs("zipped") \
    or raise StandardError, "Make dir failed to ~aevrlog/zipped!"
end

array1 = Dir.glob("dev*.log")
array2 = Dir.glob("mon*.log")
array3 = Dir.glob("fer*_se*.out")
array4 = Dir.glob("fer*_se*.log")
array5 = Dir.glob("fer*_in*.log")

if (array1.length >= 1)
    array1.each { |file|

    if (File.size(file) > FSIZE)
        File.open(file, "r+") do |f|
            if (f.flock(File::LOCK_SH)) == 0
                `/usr/bin/gzip "#{file}"`
                 FileUtils.mv("#{file}.gz","/cygdrive/c/temp/log/zipped")
            end
        end
        FileUtils.touch("development.log")
    end
    }
end

Dir.chdir("/cygdrive/c/temp/log/zipped") \
    or raise StandardError, "Change dir failed to ~aevrlog!"

array1_1 = Dir["/cygdrive/c/temp/log/zipped/dev*.gz"]

    if (array1_1.length >= 1)
        if File.exists?("development.log.11.gz")
            FileUtils.rm_r
Dir.glob("/cygdrive/c/temp/log/zipped/dev*11.gz")
        end
        if File.exists?("development.log.10.gz")
            File.rename("development.log.10.gz",
"development.log.11.gz")
        end
        if File.exists?("development.log.9.gz")
            File.rename("development.log.9.gz", "development.log.10.gz")
        end
        if File.exists?("development.log.8.gz")
            File.rename("development.log.8.gz", "development.log.9.gz")
        end
        if File.exists?("development.log.7.gz")
            File.rename("development.log.7.gz", "development.log.8.gz")
        end
        if File.exists?("development.log.6.gz")
            File.rename("development.log.6.gz", "development.log.7.gz")
        end
        if File.exists?("development.log.5.gz")
            File.rename("development.log.5.gz", "development.log.6.gz")
        end
        if File.exists?("development.log.4.gz")
            File.rename("development.log.4.gz", "development.log.5.gz")
        end
        if File.exists?("development.log.3.gz")
            File.rename("development.log.3.gz", "development.log.4.gz")
        end
        if File.exists?("development.log.2.gz")
            File.rename("development.log.2.gz", "development.log.3.gz")
        end
        if File.exists?("development.log.1.gz")
            File.rename("development.log.1.gz", "development.log.2.gz")
        end
        if File.exists?("development.log.gz")
            File.rename("development.log.gz", "development.log.1.gz")
        end
    end
47b1910084592eb77a032bc7d8d1a84e?d=identicon&s=25 Joel VanderWerf (Guest)
on 2009-05-06 03:58
(Received via mailing list)
Derek Smith wrote:
> Here is my updated code, but how do I look at the documentation from the
> CLI for logger, logging or any gem?  For example, if I want to look at
> Perl docs I use perldoc -f "builtin function" or perldoc -q "F.A.Q."

http://www.ruby-doc.org/stdlib/

Look in the left panel for "logger".

This site is still pretty useful (though I don't know if it is
frequently updated).
D15a45a973443d4562051eb675b60474?d=identicon&s=25 Tom Cloyd (Guest)
on 2009-05-06 04:28
(Received via mailing list)
Derek Smith wrote:
>
> Here is my updated code, but how do I look at the documentation from the
> CLI for logger, logging or any gem?  For example, if I want to look at
> Perl docs I use perldoc -f "builtin function" or perldoc -q "F.A.Q."
> Finally, what about a central logging block for when at anytime 'raise
> StandardError' is called, the script will log to one logfile.  Will
> anyone suggest code or how to do this?
>
>
Google "ruby logger" and you get right to the RDoc documentation -
http://www.ruby-doc.org/stdlib/libdoc/logger/rdoc/index.html

Access the "logger" class and you'll get some very good documentation.

Re: errors - the standard error stream goes to STDERR, a constant ruby
automatically creates. Normally, this goes to STDOUT - the standard
output stream, assigned to your screen, but you can reassign it:

$stderr = File.new( 'myerrs.txt','w' )

Hope this helps...

t.

--

~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Tom Cloyd, MS MA, LMHC - Private practice Psychotherapist
Bellingham, Washington, U.S.A: (360) 920-1226
<< tc@tomcloyd.com >> (email)
<< TomCloyd.com >> (website)
<< sleightmind.wordpress.com >> (mental health weblog)
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
D15a45a973443d4562051eb675b60474?d=identicon&s=25 Tom Cloyd (Guest)
on 2009-05-06 04:35
(Received via mailing list)
Derek Smith wrote:
>
> Here is my updated code, but how do I look at the documentation from the
> CLI for logger, logging or any gem?  For example, if I want to look at
> Perl docs I use perldoc -f "builtin function" or perldoc -q "F.A.Q."
> Finally, what about a central logging block for when at anytime 'raise
> StandardError' is called, the script will log to one logfile.  Will
> anyone suggest code or how to do this?
>
>
More on finding documentation -

I can't help you if you're on a Winxxxx system, but on my Kubuntu Linux
OS I can find useful documentation for the  "logger" standard library
member (and others) by  issuing at my CLI -

which logger

I get a pile of locations on the filesys where "logger" appears. Many
are irrelevant, but this one is not:

/usr/share/doc/ruby1.8-examples/examples/logger

There I find 3 ruby code files illustrating library use. Nice.

(I didn't know about this until I set out to find an answer to your
question, so thanks to you for that.)

t.

--

~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Tom Cloyd, MS MA, LMHC - Private practice Psychotherapist
Bellingham, Washington, U.S.A: (360) 920-1226
<< tc@tomcloyd.com >> (email)
<< TomCloyd.com >> (website)
<< sleightmind.wordpress.com >> (mental health weblog)
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
This topic is locked and can not be replied to.