Forum: IronRuby Review: Fix for TCPSocket.new

Announcement (2017-05-07): www.ruby-forum.com is now read-only since I unfortunately do not have the time to support and maintain the forum any more. Please see rubyonrails.org/community and ruby-lang.org/en/community for other Rails- und Ruby-related community platforms.
Aea6cfe04952626ab630bde47ff82f89?d=identicon&s=25 Shri Borde (Guest)
on 2009-04-30 22:45
(Received via mailing list)
http://github.com/shri/ironruby/commit/8c00011ba42...

With the memcache-client gem installed, the Rails tests fail to startup
as
memcache does TCPSocket.new(addr, port, 0) and we were not handling the
third argument

Files changed:

 *
Merlin/External.LCA_RESTRICTED/Languages/IronRuby/mspec/ironruby-tags/library/socket/tcpsocket/new_tags.txt<http://github.com/shri/ironruby/commit/8c00011ba42...
 *
Merlin/External.LCA_RESTRICTED/Languages/IronRuby/mspec/ironruby-tags/library/socket/tcpsocket/open_tags.txt<http://github.com/shri/ironruby/commit/8c00011ba42...
 *
Merlin/External.LCA_RESTRICTED/Languages/IronRuby/mspec/rubyspec/library/socket/fixtures/classes.rb<http://github.com/shri/ironruby/commit/8c00011ba42...
 *
Merlin/External.LCA_RESTRICTED/Languages/IronRuby/mspec/rubyspec/library/socket/tcpsocket/shared/new.rb<http://github.com/shri/ironruby/commit/8c00011ba42...
 *
Merlin/Main/Languages/Ruby/ClassInitGenerator/ClassInitGenerator.csproj<http://github.com/shri/ironruby/commit/8c00011ba42...
 *
Merlin/Main/Languages/Ruby/Libraries.LCA_RESTRICTED/Initializers.Generated.cs<http://github.com/shri/ironruby/commit/8c00011ba42...
 *
Merlin/Main/Languages/Ruby/Libraries.LCA_RESTRICTED/socket/TCPSocket.cs<http://github.com/shri/ironruby/commit/8c00011ba42...
Thanks,
Shri
Ade8632553a9243ae05fc920f68644c1?d=identicon&s=25 Jim Deville (Guest)
on 2009-05-13 23:56
(Received via mailing list)
This looks mostly good. My only comment is that I would suggest
combining the it "allows local_port to be 0 when local_host is not
specified" do and it "requires local_port to be 0 when local_host is not
specified" specs, since, IMHO, the requirement/allowance is different
views on the same facet of behavior.


JD

...there is no try

From: Shri Borde
Sent: Thursday, April 30, 2009 1:45 PM
To: ironruby-core@rubyforge.org
Cc: IronRuby External Code Reviewers
Subject: Review: Fix for TCPSocket.new

http://github.com/shri/ironruby/commit/8c00011ba42...

With the memcache-client gem installed, the Rails tests fail to startup
as
memcache does TCPSocket.new(addr, port, 0) and we were not handling the
third argument

Files changed:

  *
Merlin/External.LCA_RESTRICTED/Languages/IronRuby/mspec/ironruby-tags/library/socket/tcpsocket/new_tags.txt<http://github.com/shri/ironruby/commit/8c00011ba42...
  *
Merlin/External.LCA_RESTRICTED/Languages/IronRuby/mspec/ironruby-tags/library/socket/tcpsocket/open_tags.txt<http://github.com/shri/ironruby/commit/8c00011ba42...
  *
Merlin/External.LCA_RESTRICTED/Languages/IronRuby/mspec/rubyspec/library/socket/fixtures/classes.rb<http://github.com/shri/ironruby/commit/8c00011ba42...
  *
Merlin/External.LCA_RESTRICTED/Languages/IronRuby/mspec/rubyspec/library/socket/tcpsocket/shared/new.rb<http://github.com/shri/ironruby/commit/8c00011ba42...
  *
Merlin/Main/Languages/Ruby/ClassInitGenerator/ClassInitGenerator.csproj<http://github.com/shri/ironruby/commit/8c00011ba42...
  *
Merlin/Main/Languages/Ruby/Libraries.LCA_RESTRICTED/Initializers.Generated.cs<http://github.com/shri/ironruby/commit/8c00011ba42...
  *
Merlin/Main/Languages/Ruby/Libraries.LCA_RESTRICTED/socket/TCPSocket.cs<http://github.com/shri/ironruby/commit/8c00011ba42...
Thanks,
Shri
This topic is locked and can not be replied to.