Forum: IronRuby Code Review: core/module/autoload

Announcement (2017-05-07): www.ruby-forum.com is now read-only since I unfortunately do not have the time to support and maintain the forum any more. Please see rubyonrails.org/community and ruby-lang.org/en/community for other Rails- und Ruby-related community platforms.
E1deaac6561498a0e7472e6268ea9ccc?d=identicon&s=25 Jimmy Schementi (Guest)
on 2009-04-21 08:52
(Received via mailing list)
http://github.com/jschementi/ironruby/commit/bbfa3...

autoload uses '/' to join load-path and autoload-path.
Fixes http://ironruby.codeplex.com/WorkItem/View.aspx?Wo...

This makes Rails 2.3.2 startup without any modifications! =)

Changes:
-
Merlin/External.LCA_RESTRICTED/Languages/IronRuby/mspec/rubyspec/core/module/autoload_spec.rb
-
Merlin/External.LCA_RESTRICTED/Languages/IronRuby/mspec/rubyspec/core/module/fixtures/autoload_join.rb
- Merlin/Main/Languages/Ruby/Ruby/Runtime/Loader.cs
Ade8632553a9243ae05fc920f68644c1?d=identicon&s=25 Jim Deville (Guest)
on 2009-04-21 09:35
(Received via mailing list)
Looks good.

JD
Cb51033949ffccd982ae32c9f890f25a?d=identicon&s=25 Tomas Matousek (Guest)
on 2009-04-21 17:37
(Received via mailing list)
/ is not appended if the path ends with /. It is if it ends with \ -
which seems like a bug in Ruby that we shouldn't copy.
Could you rather implement " Combine" somewhere (in RubyUtils e.g.) that
uses / for joining paths but checks if the directory ends with \ or /?

Tomas
E1deaac6561498a0e7472e6268ea9ccc?d=identicon&s=25 Jimmy Schementi (Guest)
on 2009-04-22 20:59
(Received via mailing list)
http://github.com/jschementi/ironruby/commit/78bd7...

Code review updates:
- Don't combine paths with '/' if the base-path already ends with '/' or
'\\'

    * Merlin/Main/Languages/Ruby/Ruby/Runtime/Loader.cs
    * Merlin/Main/Languages/Ruby/Ruby/Runtime/RubyUtils.cs
Cb51033949ffccd982ae32c9f890f25a?d=identicon&s=25 Tomas Matousek (Guest)
on 2009-04-22 21:18
(Received via mailing list)
Looks good.

Tomas
This topic is locked and can not be replied to.