Forum: IronRuby Code Review: Allows symbols to be in a YAML array

Announcement (2017-05-07): www.ruby-forum.com is now read-only since I unfortunately do not have the time to support and maintain the forum any more. Please see rubyonrails.org/community and ruby-lang.org/en/community for other Rails- und Ruby-related community platforms.
E1deaac6561498a0e7472e6268ea9ccc?d=identicon&s=25 Jimmy Schementi (Guest)
on 2009-04-12 01:42
(Received via mailing list)
http://github.com/jschementi/ironruby/commit/e8406...

Allows symbols to be in a YAML array ("date: [:year, :month, :day]").
Fixes http://ironruby.codeplex.com/WorkItem/View.aspx?Wo....

(Shri: gitdiff wasn't working for me, is there any setup I need to do?)
Aea6cfe04952626ab630bde47ff82f89?d=identicon&s=25 Shri Borde (Guest)
on 2009-04-13 07:50
(Received via mailing list)
GitDiff.bat just builds on top of the GIT_EXTERNAL_DIFF environment
variable mentioned at
http://kernel.org/pub/software/scm/git/docs/v1.0.1....
Can you do "set GIT_EXTERNAL_DIFF=echo" and then run a "git diff"
command. If that runs to completion, GitDiff.bat should work as well. We
can take a look tomorrow...

Shri

From: Jimmy Schementi
Sent: Saturday, April 11, 2009 4:42 PM
To: ironruby-core@rubyforge.org
Cc: IronRuby External Code Reviewers
Subject: Code Review: Allows symbols to be in a YAML array

http://github.com/jschementi/ironruby/commit/e8406...

Allows symbols to be in a YAML array ("date: [:year, :month, :day]").
Fixes http://ironruby.codeplex.com/WorkItem/View.aspx?Wo....

(Shri: gitdiff wasn't working for me, is there any setup I need to do?)
Ade8632553a9243ae05fc920f68644c1?d=identicon&s=25 Jim Deville (Guest)
on 2009-04-14 21:02
(Received via mailing list)
In the spec, why not use each_with_index instead of times?
(http://github.com/jschementi/ironruby/commit/e8406...)

Other than that, looks good.

JD

From: Jimmy Schementi
Sent: Saturday, April 11, 2009 4:42 PM
To: ironruby-core@rubyforge.org
Cc: IronRuby External Code Reviewers
Subject: Code Review: Allows symbols to be in a YAML array

http://github.com/jschementi/ironruby/commit/e8406...

Allows symbols to be in a YAML array ("date: [:year, :month, :day]").
Fixes http://ironruby.codeplex.com/WorkItem/View.aspx?Wo....

(Shri: gitdiff wasn't working for me, is there any setup I need to do?)
E1deaac6561498a0e7472e6268ea9ccc?d=identicon&s=25 Jimmy Schementi (Guest)
on 2009-04-16 00:22
(Received via mailing list)
File.dirname now uses [NotNull] instead of an explicit check on path:
http://github.com/jschementi/ironruby/commit/8235f...
Jim said spec changes were fine. This is in my master github branch now,
and Jim is pulling it in to the main repo shortly.

One more bug fix (autoload) left until Rails starts!

From: Jim Deville
Sent: Tuesday, April 14, 2009 11:45 AM
To: Jimmy Schementi; ironruby-core@rubyforge.org
Cc: IronRuby External Code Reviewers
Subject: RE: Code Review: Allows symbols to be in a YAML array

In the spec, why not use each_with_index instead of times?
(http://github.com/jschementi/ironruby/commit/e8406...)

Other than that, looks good.

JD

From: Jimmy Schementi
Sent: Saturday, April 11, 2009 4:42 PM
To: ironruby-core@rubyforge.org
Cc: IronRuby External Code Reviewers
Subject: Code Review: Allows symbols to be in a YAML array

http://github.com/jschementi/ironruby/commit/e8406...

Allows symbols to be in a YAML array ("date: [:year, :month, :day]").
Fixes http://ironruby.codeplex.com/WorkItem/View.aspx?Wo....

(Shri: gitdiff wasn't working for me, is there any setup I need to do?)
This topic is locked and can not be replied to.