Forum: IronRuby Review: String#% and File.rename

Announcement (2017-05-07): www.ruby-forum.com is now read-only since I unfortunately do not have the time to support and maintain the forum any more. Please see rubyonrails.org/community and ruby-lang.org/en/community for other Rails- und Ruby-related community platforms.
Aea6cfe04952626ab630bde47ff82f89?d=identicon&s=25 Shri Borde (Guest)
on 2009-04-09 21:25
(Received via mailing list)
http://github.com/Jirapong/ironruby/commit/1eb5b38...
(Jirapong's fix)
http://github.com/shri/ironruby/commit/2cb2802a316...
(my fixes)
http://github.com/shri/ironruby/commit/e8f840f5c80...
(merge with irmain HEAD)

GitDiff.bat fb6f89146e331a9f20f444d5ca94478dfce7f555
2cb2802a316c48721875204aa83cf5d0fa85cf3f


*         Jirapong's fix for File.new when file already exists

*         Fixed another bug in String#%

*         Bugs in File.rename

*         Ruby should exit when main thread exits, even if other threads
are still alive

*         Mapped Errno::ENOENT to FleNotFoundException, and ENOTDIR to
DirectoryNotFoundException

Files changed:

 *
Merlin/External/Languages/IronRuby/mspec/ironruby-tags/core/string/modulo_tags.txt<http://github.com/shri/ironruby/commit/2cb2802a316...
 *
Merlin/External/Languages/IronRuby/mspec/rubyspec/core/file/rename_spec.rb<http://github.com/shri/ironruby/commit/2cb2802a316...
 *
Merlin/External/Languages/IronRuby/mspec/rubyspec/core/string/modulo_spec.rb<http://github.com/shri/ironruby/commit/2cb2802a316...
 *
Merlin/External/Languages/IronRuby/mspec/rubyspec/core/thread/new_spec.rb<http://github.com/shri/ironruby/commit/2cb2802a316...
 *
Merlin/Main/Languages/Ruby/Libraries.LCA_RESTRICTED/Builtins/Dir.cs<http://github.com/shri/ironruby/commit/2cb2802a316...
 *
Merlin/Main/Languages/Ruby/Libraries.LCA_RESTRICTED/Builtins/Errno.cs<http://github.com/shri/ironruby/commit/2cb2802a316...
 *
Merlin/Main/Languages/Ruby/Libraries.LCA_RESTRICTED/Builtins/FileOps.cs<http://github.com/shri/ironruby/commit/2cb2802a316...
 *
Merlin/Main/Languages/Ruby/Libraries.LCA_RESTRICTED/Builtins/IoOps.cs<http://github.com/shri/ironruby/commit/2cb2802a316...
 *
Merlin/Main/Languages/Ruby/Libraries.LCA_RESTRICTED/Builtins/KernelOps.cs<http://github.com/shri/ironruby/commit/2cb2802a316...
 *
Merlin/Main/Languages/Ruby/Libraries.LCA_RESTRICTED/Builtins/StringFormatter.cs<http://github.com/shri/ironruby/commit/2cb2802a316...
 *
Merlin/Main/Languages/Ruby/Libraries.LCA_RESTRICTED/Builtins/ThreadOps.cs<http://github.com/shri/ironruby/commit/2cb2802a316...
 *
Merlin/Main/Languages/Ruby/Libraries.LCA_RESTRICTED/Initializers.Generated.cs<http://github.com/shri/ironruby/commit/2cb2802a316...
 *
Merlin/Main/Languages/Ruby/Tests/Interop/uncategorized_spec.rb<http://github.com/shri/ironruby/commit/2cb2802a316...
 *   Merlin/Main/Languages/Ruby/Tests/Interop/uncategorized_specs.rb
 *
Merlin/Users/sborde/Dev.bat<http://github.com/shri/ironruby/commit/2cb2802a316...
Thanks,
Shri
Cb51033949ffccd982ae32c9f890f25a?d=identicon&s=25 Tomas Matousek (Guest)
on 2009-04-09 22:18
(Received via mailing list)
Looks good.

Tomas

From: Shri Borde
Sent: Thursday, April 09, 2009 12:06 PM
To: IronRuby External Code Reviewers
Cc: ironruby-core@rubyforge.org
Subject: Review: String#% and File.rename

http://github.com/Jirapong/ironruby/commit/1eb5b38...
(Jirapong's fix)
http://github.com/shri/ironruby/commit/2cb2802a316...
(my fixes)
http://github.com/shri/ironruby/commit/e8f840f5c80...
(merge with irmain HEAD)

GitDiff.bat fb6f89146e331a9f20f444d5ca94478dfce7f555
2cb2802a316c48721875204aa83cf5d0fa85cf3f


*         Jirapong's fix for File.new when file already exists

*         Fixed another bug in String#%

*         Bugs in File.rename

*         Ruby should exit when main thread exits, even if other threads
are still alive

*         Mapped Errno::ENOENT to FleNotFoundException, and ENOTDIR to
DirectoryNotFoundException

Files changed:

 *
Merlin/External/Languages/IronRuby/mspec/ironruby-tags/core/string/modulo_tags.txt<http://github.com/shri/ironruby/commit/2cb2802a316...
 *
Merlin/External/Languages/IronRuby/mspec/rubyspec/core/file/rename_spec.rb<http://github.com/shri/ironruby/commit/2cb2802a316...
 *
Merlin/External/Languages/IronRuby/mspec/rubyspec/core/string/modulo_spec.rb<http://github.com/shri/ironruby/commit/2cb2802a316...
 *
Merlin/External/Languages/IronRuby/mspec/rubyspec/core/thread/new_spec.rb<http://github.com/shri/ironruby/commit/2cb2802a316...
 *
Merlin/Main/Languages/Ruby/Libraries.LCA_RESTRICTED/Builtins/Dir.cs<http://github.com/shri/ironruby/commit/2cb2802a316...
 *
Merlin/Main/Languages/Ruby/Libraries.LCA_RESTRICTED/Builtins/Errno.cs<http://github.com/shri/ironruby/commit/2cb2802a316...
 *
Merlin/Main/Languages/Ruby/Libraries.LCA_RESTRICTED/Builtins/FileOps.cs<http://github.com/shri/ironruby/commit/2cb2802a316...
 *
Merlin/Main/Languages/Ruby/Libraries.LCA_RESTRICTED/Builtins/IoOps.cs<http://github.com/shri/ironruby/commit/2cb2802a316...
 *
Merlin/Main/Languages/Ruby/Libraries.LCA_RESTRICTED/Builtins/KernelOps.cs<http://github.com/shri/ironruby/commit/2cb2802a316...
 *
Merlin/Main/Languages/Ruby/Libraries.LCA_RESTRICTED/Builtins/StringFormatter.cs<http://github.com/shri/ironruby/commit/2cb2802a316...
 *
Merlin/Main/Languages/Ruby/Libraries.LCA_RESTRICTED/Builtins/ThreadOps.cs<http://github.com/shri/ironruby/commit/2cb2802a316...
 *
Merlin/Main/Languages/Ruby/Libraries.LCA_RESTRICTED/Initializers.Generated.cs<http://github.com/shri/ironruby/commit/2cb2802a316...
 *
Merlin/Main/Languages/Ruby/Tests/Interop/uncategorized_spec.rb<http://github.com/shri/ironruby/commit/2cb2802a316...
 *   Merlin/Main/Languages/Ruby/Tests/Interop/uncategorized_specs.rb
 *
Merlin/Users/sborde/Dev.bat<http://github.com/shri/ironruby/commit/2cb2802a316...
Thanks,
Shri
Ade8632553a9243ae05fc920f68644c1?d=identicon&s=25 Jim Deville (Guest)
on 2009-04-09 23:21
(Received via mailing list)
I would suggest using FileUtils.rm_rf instead of remove_dir at
http://github.com/shri/ironruby/commit/2cb2802a316...

You also don't need to require fileutils as it is required as part of
MSpec.

JD


From: Shri Borde
Sent: Thursday, April 09, 2009 12:06 PM
To: IronRuby External Code Reviewers
Cc: ironruby-core@rubyforge.org
Subject: Review: String#% and File.rename

http://github.com/Jirapong/ironruby/commit/1eb5b38...
(Jirapong's fix)
http://github.com/shri/ironruby/commit/2cb2802a316...
(my fixes)
http://github.com/shri/ironruby/commit/e8f840f5c80...
(merge with irmain HEAD)

GitDiff.bat fb6f89146e331a9f20f444d5ca94478dfce7f555
2cb2802a316c48721875204aa83cf5d0fa85cf3f


*         Jirapong's fix for File.new when file already exists

*         Fixed another bug in String#%

*         Bugs in File.rename

*         Ruby should exit when main thread exits, even if other threads
are still alive

*         Mapped Errno::ENOENT to FleNotFoundException, and ENOTDIR to
DirectoryNotFoundException

Files changed:

  *
Merlin/External/Languages/IronRuby/mspec/ironruby-tags/core/string/modulo_tags.txt<http://github.com/shri/ironruby/commit/2cb2802a316...
  *
Merlin/External/Languages/IronRuby/mspec/rubyspec/core/file/rename_spec.rb<http://github.com/shri/ironruby/commit/2cb2802a316...
  *
Merlin/External/Languages/IronRuby/mspec/rubyspec/core/string/modulo_spec.rb<http://github.com/shri/ironruby/commit/2cb2802a316...
  *
Merlin/External/Languages/IronRuby/mspec/rubyspec/core/thread/new_spec.rb<http://github.com/shri/ironruby/commit/2cb2802a316...
  *
Merlin/Main/Languages/Ruby/Libraries.LCA_RESTRICTED/Builtins/Dir.cs<http://github.com/shri/ironruby/commit/2cb2802a316...
  *
Merlin/Main/Languages/Ruby/Libraries.LCA_RESTRICTED/Builtins/Errno.cs<http://github.com/shri/ironruby/commit/2cb2802a316...
  *
Merlin/Main/Languages/Ruby/Libraries.LCA_RESTRICTED/Builtins/FileOps.cs<http://github.com/shri/ironruby/commit/2cb2802a316...
  *
Merlin/Main/Languages/Ruby/Libraries.LCA_RESTRICTED/Builtins/IoOps.cs<http://github.com/shri/ironruby/commit/2cb2802a316...
  *
Merlin/Main/Languages/Ruby/Libraries.LCA_RESTRICTED/Builtins/KernelOps.cs<http://github.com/shri/ironruby/commit/2cb2802a316...
  *
Merlin/Main/Languages/Ruby/Libraries.LCA_RESTRICTED/Builtins/StringFormatter.cs<http://github.com/shri/ironruby/commit/2cb2802a316...
  *
Merlin/Main/Languages/Ruby/Libraries.LCA_RESTRICTED/Builtins/ThreadOps.cs<http://github.com/shri/ironruby/commit/2cb2802a316...
  *
Merlin/Main/Languages/Ruby/Libraries.LCA_RESTRICTED/Initializers.Generated.cs<http://github.com/shri/ironruby/commit/2cb2802a316...
  *
Merlin/Main/Languages/Ruby/Tests/Interop/uncategorized_spec.rb<http://github.com/shri/ironruby/commit/2cb2802a316...
  *   Merlin/Main/Languages/Ruby/Tests/Interop/uncategorized_specs.rb
  *
Merlin/Users/sborde/Dev.bat<http://github.com/shri/ironruby/commit/2cb2802a316...
Thanks,
Shri
This topic is locked and can not be replied to.