Forum: IronRuby FYI review - Jirapong's fixes for GzipFile#finish

Announcement (2017-05-07): www.ruby-forum.com is now read-only since I unfortunately do not have the time to support and maintain the forum any more. Please see rubyonrails.org/community and ruby-lang.org/en/community for other Rails- und Ruby-related community platforms.
Aea6cfe04952626ab630bde47ff82f89?d=identicon&s=25 Shri Borde (Guest)
on 2009-04-02 21:38
(Received via mailing list)
FYI review only...

This is Jirapong's change. A big thanks to Jirapong for his first
contribution to IronRuby! Looking forward to many more!

I have pushed it to my fork. The individual commits are shown below, but
there will be a bit of noise as Jirapong bounced questions off me. I
should probably have squashed his individual commits into one to remove
the noise. Might do that for the next round...

http://github.com/shri/ironruby/commit/62b0d91e3fd...
http://github.com/shri/ironruby/commit/88a3902ffa3...
http://github.com/shri/ironruby/commit/24b069c0a8f...
http://github.com/Jirapong/ironruby/commit/2926dd7...
http://github.com/shri/ironruby/commit/ec7270c2934...
- My code review
http://github.com/shri/ironruby/commit/c71e026eca1...

GitDiff.bat c9a26adb7c443afc192514c72806e95b178d5088
c71e026eca1134d77a87bd792b1d93c60e32bf81

GzipFile#finish should close the GzipReader/GzipWriter, but not the
underlying IO object.

Thanks,
Shri
Ade8632553a9243ae05fc920f68644c1?d=identicon&s=25 Jim Deville (Guest)
on 2009-04-02 22:54
(Received via mailing list)
The debugger method shouldn't be in spec_helper.rb. It's a IronRuby
specific method and that file is a MSpec file. Also, it's missing an
end.

Other than that, test looks good.

JD

From: Shri Borde
Sent: Thursday, April 02, 2009 12:08 PM
To: IronRuby External Code Reviewers
Cc: ironruby-core@rubyforge.org
Subject: FYI review - Jirapong's fixes for GzipFile#finish

FYI review only...

This is Jirapong's change. A big thanks to Jirapong for his first
contribution to IronRuby! Looking forward to many more!

I have pushed it to my fork. The individual commits are shown below, but
there will be a bit of noise as Jirapong bounced questions off me. I
should probably have squashed his individual commits into one to remove
the noise. Might do that for the next round...

http://github.com/shri/ironruby/commit/62b0d91e3fd...
http://github.com/shri/ironruby/commit/88a3902ffa3...
http://github.com/shri/ironruby/commit/24b069c0a8f...
http://github.com/Jirapong/ironruby/commit/2926dd7...
http://github.com/shri/ironruby/commit/ec7270c2934...
- My code review
http://github.com/shri/ironruby/commit/c71e026eca1...

GitDiff.bat c9a26adb7c443afc192514c72806e95b178d5088
c71e026eca1134d77a87bd792b1d93c60e32bf81

GzipFile#finish should close the GzipReader/GzipWriter, but not the
underlying IO object.

Thanks,
Shri
This topic is locked and can not be replied to.