Forum: Ruby on Rails rails 2.3 test failure - is this all it takes?

Announcement (2017-05-07): www.ruby-forum.com is now read-only since I unfortunately do not have the time to support and maintain the forum any more. Please see rubyonrails.org/community and ruby-lang.org/en/community for other Rails- und Ruby-related community platforms.
40db9e75b3f5899258e3bdc0c9210154?d=identicon&s=25 Conrad Taylor (conradwt)
on 2009-03-05 09:31
(Received via mailing list)
On Wed, Mar 4, 2009 at 9:14 PM, Richard Lloyd
<richard.t.lloyd@gmail.com>wrote:

> Conrad,
>
> I just commented out line 10 from
> activesupport-2.3.0/lib/activesupport/test_case.rb and the test ran to
> completion.
>
> Rick
>

Hi Rick, I would recommend following this tutorial for contributing
fixes to
the Rails project because Ryan Bates does
a wonderful job:

http://railscasts.com/episodes/113-contributing-to...

In this screenast, Ryan Bates walks through the entire process:

a)  cloning rails
b)  testing the part of the framework that you're interested in (i.e.
activesupport in your case) before fixing and/or enhancing
c)  if (b) passes, then your fix isn't necessary.  Otherwise, continue
to
(d)
d)  create a separate branch for you fix
e)  create the relevant test by adding it to the relevant test file or
creating a new one test file for it
f)   execute the test file and it should produce the failure
g)  edit the relevant source file
h)  rerun the test from (e)
i)   add documentation to the source file in (g)
j)   commit the changes
k)  perform a 'git pull' on the master branch
l)   checkout your branch from (d)
m) add your changes to the last commit that was made by executing 'git
rebase master'
n)  generate the patch
o)  submit a ticket to lighthouse with a title, description, and
relevant
tags.  Then attach your patch from (n) to the ticket and submit it.

Last but not least, the Rails core group can be found here:

http://groups.google.com/group/rubyonrails-core

Good luck,

-Conrad
This topic is locked and can not be replied to.