Forum: Ruby on Rails Bug in plug-in open_id_authentication

Announcement (2017-05-07): www.ruby-forum.com is now read-only since I unfortunately do not have the time to support and maintain the forum any more. Please see rubyonrails.org/community and ruby-lang.org/en/community for other Rails- und Ruby-related community platforms.
115b71c0a1c9d92d0b78d51cd0174ee6?d=identicon&s=25 Vikrant (Guest)
on 2009-02-26 11:09
(Received via mailing list)
Hi,
There is a little bug in open_id_authentication plug-in at line 87 of
file lib/open_id_authentication.rb

  identifier = "http://#{identifier}" unless identifier =~ /^http/i

this line will silently ignore the uri "httpd.apache.org" without
normalising it to "http://httpd.apache.org/"

at present, writing OpenIdAuthentication.normalize_identifier
('httpd.apache.org') raises a NoMethodError.

Proposed solution is to replace /^http/i with /^http:/i

   identifier = "http://#{identifier}" unless identifier =~ /^http:/i

http://github.com/rails/open_id_authentication/blo...

I'm reporting this bug here, because don't know how to submit patch
(or whatever we call it) for Git repository. Also guys at
lighthouseapp.com will let you sign-in with an OpenID but won't let
you sign-up with one! So bad.
115b71c0a1c9d92d0b78d51cd0174ee6?d=identicon&s=25 Vikrant (Guest)
on 2009-03-16 15:04
(Received via mailing list)
there is a bug, it actually should be -
 identifier = "http://#{identifier}" unless identifier =~ /^https?:/i
This topic is locked and can not be replied to.