Forum: IronRuby Code Review: netinterop1

Announcement (2017-05-07): www.ruby-forum.com is now read-only since I unfortunately do not have the time to support and maintain the forum any more. Please see rubyonrails.org/community and ruby-lang.org/en/community for other Rails- und Ruby-related community platforms.
Ade8632553a9243ae05fc920f68644c1?d=identicon&s=25 Jim Deville (Guest)
on 2009-01-26 22:10
(Received via mailing list)
Attachment: netinterop1.diff (30 KB)
tfpt review "/shelveset:netinterop1;REDMOND\jdeville"
  Comment  :
  More tests for .net interop. This is taking advantage of the IronRuby
selfhosting that Tomas blogged about in order to maintain isolation as I
run different styles of requiring files. If you add
Merlin/External/Languages/IronRuby/mspec/mspec/bin to your path, you
should be able to run these with "mspec -fs /path/to/Interop/Load"
573b9499030e1ccb867ef80f0ff1ac49?d=identicon&s=25 Justin Bailey (Guest)
on 2009-01-26 23:31
(Received via mailing list)
On Mon, Jan 26, 2009 at 1:03 PM, Jim Deville <jdeville@microsoft.com>
wrote:
>  tfpt review "/shelveset:netinterop1;REDMOND\jdeville"
>  Comment  :
>  More tests for .net interop. This is taking advantage of the IronRuby selfhosting that 
Tomas blogged about in order to maintain

Where can I find Tomas' blog? I'd like to subscribe but I didn't see
it on the IronRuby "people" page:

http://ironruby.net/About/People

Justin
573b9499030e1ccb867ef80f0ff1ac49?d=identicon&s=25 Justin Bailey (Guest)
on 2009-01-26 23:33
(Received via mailing list)
The best way to answer your own question - post to a mailing list! I
found a nice blogroll post by Oleg:

  http://www.tkachenko.com/blog/archives/000747.html

Maybe someone can update the people page? I would but I haven't
created an account and am pressed for time as it is ...

Justin
Cb51033949ffccd982ae32c9f890f25a?d=identicon&s=25 Tomas Matousek (Guest)
on 2009-01-27 00:08
(Received via mailing list)
Fixed :)

Tomas
Ade8632553a9243ae05fc920f68644c1?d=identicon&s=25 Jim Deville (Guest)
on 2009-01-31 08:05
(Received via mailing list)
Srivatsn,

Can you take a look?

JD
E1deaac6561498a0e7472e6268ea9ccc?d=identicon&s=25 Jimmy Schementi (Guest)
on 2009-02-04 23:25
(Received via mailing list)
Sorry about the delay on this. Here are my comments:

1. Does MSpec have shared behaviors, like Rake or Bacon? If so, you
should try to remove the duplication of managing engines and whatnot
that you have in before/after blocks. For example:

shared ".NET Test" do
  before { @engine = IronRuby.create_engine }
  after { @engine = nil }
end

describe "Midifying and reloading a .NET BCL Assembly" do
  behaves_like ".NET Test"
end

2. There's a lot of duplication in the "Repeated loading of a .NET BCL
assembly with Strong name", and examples like that, so can you do
something like this:

it "only loads once with require followed by require" do
  [true, false].each do |t|
    @engine.execute("require 'System.Core, Version=3.5.0.0,
Culture=neutral, PublicKeyToken=b77a5c561934e089'").should == t
  end
end

or where the loading mechanism changes

it "loads twice with load followed by load_assembly" do
  ['load', 'load_assembly'].each do |t|
    @engine.execute("#{t} 'System.Core, Version=3.5.0.0,
Culture=neutral, PublicKeyToken=b77a5c561934e089'").should == true
  end
end

Otherwise, it's a great start!
Ade8632553a9243ae05fc920f68644c1?d=identicon&s=25 Jim Deville (Guest)
on 2009-02-06 03:18
(Received via mailing list)
Attachment: netinterop1.diff (20 KB)
Updated shelveset, and diff.

JD
This topic is locked and can not be replied to.