Forum: IronRuby Code Review: IronRuby Thread fixes

Announcement (2017-05-07): www.ruby-forum.com is now read-only since I unfortunately do not have the time to support and maintain the forum any more. Please see rubyonrails.org/community and ruby-lang.org/en/community for other Rails- und Ruby-related community platforms.
Aea6cfe04952626ab630bde47ff82f89?d=identicon&s=25 Shri Borde (Guest)
on 2008-12-16 23:44
(Received via mailing list)
Attachment: Thread.diff (30 KB)
Affects: Microsoft.Scripting.Core.dll and IronRuby



  tfpt review "/shelveset:Thread;REDMOND\sborde"



  Comment  :

  Fixes to all the currently disabled Thread tests

  Thread#stop/Kernel#sleep use an Event which can be signalled from
other threads, instead of using Thread.Sleep

  ThreadOps.CreateThread catches and ignores ThreadAbortException
instead of publishing it as RubyThreadInfo.Exception

  Thread#main - its per ScriptRuntime, mainly because that was easier to
implement, and also there is no good answer to how Thread#main should
function in hosted scenarios

  Adds lock to RubyModule.EnsureInitialized to prevent use of
uninitialized modules in multi-thread scenarios.

  Changes RunRSpec.cmd to match the flags used by "rake why_regression"



Microsoft.Scripting.Core:

  Fixes ExpressionWriter to deal with GotoExpression.Value being null in
VisitGoto
Ade8632553a9243ae05fc920f68644c1?d=identicon&s=25 Jim Deville (Guest)
on 2008-12-17 00:44
(Received via mailing list)
Test changes look good. I'd like to see the RunRSpec.cmd use ruby to run
mspec with args of ci and -t "path to ir", which is what the rakefile
sets up as a command line.

JD

From: Shri Borde
Sent: Tuesday, December 16, 2008 2:39 PM
To: IronRuby External Code Reviewers; Rowan Code Reviewers; DLR Code
Reviews
Cc: ironruby-core@rubyforge.org
Subject: Code Review: IronRuby Thread fixes


Affects: Microsoft.Scripting.Core.dll and IronRuby



  tfpt review "/shelveset:Thread;REDMOND\sborde"



  Comment  :

  Fixes to all the currently disabled Thread tests

  Thread#stop/Kernel#sleep use an Event which can be signalled from
other threads, instead of using Thread.Sleep

  ThreadOps.CreateThread catches and ignores ThreadAbortException
instead of publishing it as RubyThreadInfo.Exception

  Thread#main - its per ScriptRuntime, mainly because that was easier to
implement, and also there is no good answer to how Thread#main should
function in hosted scenarios

  Adds lock to RubyModule.EnsureInitialized to prevent use of
uninitialized modules in multi-thread scenarios.

  Changes RunRSpec.cmd to match the flags used by "rake why_regression"



Microsoft.Scripting.Core:

  Fixes ExpressionWriter to deal with GotoExpression.Value being null in
VisitGoto
Ea3ab195d54e8a1a10bda41f50a1c690?d=identicon&s=25 John Messerly (Guest)
on 2008-12-17 01:22
(Received via mailing list)
DLR change looks great!

From: Shri Borde
Sent: Tuesday, December 16, 2008 2:39 PM
To: IronRuby External Code Reviewers; Rowan Code Reviewers; DLR Code
Reviews
Cc: ironruby-core@rubyforge.org
Subject: Code Review: IronRuby Thread fixes


Affects: Microsoft.Scripting.Core.dll and IronRuby



  tfpt review "/shelveset:Thread;REDMOND\sborde"



  Comment  :

  Fixes to all the currently disabled Thread tests

  Thread#stop/Kernel#sleep use an Event which can be signalled from
other threads, instead of using Thread.Sleep

  ThreadOps.CreateThread catches and ignores ThreadAbortException
instead of publishing it as RubyThreadInfo.Exception

  Thread#main - its per ScriptRuntime, mainly because that was easier to
implement, and also there is no good answer to how Thread#main should
function in hosted scenarios

  Adds lock to RubyModule.EnsureInitialized to prevent use of
uninitialized modules in multi-thread scenarios.

  Changes RunRSpec.cmd to match the flags used by "rake why_regression"



Microsoft.Scripting.Core:

  Fixes ExpressionWriter to deal with GotoExpression.Value being null in
VisitGoto
F983f0c990cba2fe743ef62a975ec99c?d=identicon&s=25 Curt Hagenlocher (Guest)
on 2008-12-17 17:42
(Received via mailing list)
Ruby changes are good.

From: Shri Borde
Sent: Tuesday, December 16, 2008 2:39 PM
To: IronRuby External Code Reviewers; Rowan Code Reviewers; DLR Code
Reviews
Cc: ironruby-core@rubyforge.org
Subject: Code Review: IronRuby Thread fixes


Affects: Microsoft.Scripting.Core.dll and IronRuby



  tfpt review "/shelveset:Thread;REDMOND\sborde"



  Comment  :

  Fixes to all the currently disabled Thread tests

  Thread#stop/Kernel#sleep use an Event which can be signalled from
other threads, instead of using Thread.Sleep

  ThreadOps.CreateThread catches and ignores ThreadAbortException
instead of publishing it as RubyThreadInfo.Exception

  Thread#main - its per ScriptRuntime, mainly because that was easier to
implement, and also there is no good answer to how Thread#main should
function in hosted scenarios

  Adds lock to RubyModule.EnsureInitialized to prevent use of
uninitialized modules in multi-thread scenarios.

  Changes RunRSpec.cmd to match the flags used by "rake why_regression"



Microsoft.Scripting.Core:

  Fixes ExpressionWriter to deal with GotoExpression.Value being null in
VisitGoto
This topic is locked and can not be replied to.