Forum: IronRuby Code Review: MoreSites4

Announcement (2017-05-07): www.ruby-forum.com is now read-only since I unfortunately do not have the time to support and maintain the forum any more. Please see rubyonrails.org/community and ruby-lang.org/en/community for other Rails- und Ruby-related community platforms.
Cb51033949ffccd982ae32c9f890f25a?d=identicon&s=25 Tomas Matousek (Guest)
on 2008-12-10 03:21
(Received via mailing list)
Attachment: MoreSites4.diff (700 KB)
tfpt review "/shelveset:MoreSites4;REDMOND\tomat"

DLR change:
  Inherits SiteLocalStorage<T> from SiteLocalStorage class and enables
any subclass of SiteLocalStorage to be created as a storage for data in
a rule.

Ruby:
  Implements multiple SiteLocalStorage subclasses for the most frequent
site storage types: CallSiteStorage, BinaryOpStorage, UnaryOpStorage,
ConversionStorage.
  Implements ConvertToHashAction, fixes implementation of
ConvertToSAction.
  Conversion actions now use RubyContext not RubyScope. This simplifies
their calls from libraries yet causes a minor incompatibility with MRI:
if a parameter-less method that works with a local scope, such as
"private", is aliased and given the name of a conversion method ("to_s",
e.g.) and a conversion of an object with such aliased method is
attempted, the scope-manipulating method fails to update the scope
properly. This is not a real world scenario so it should be fine to
ignore it. The fix would require to define 2 instances of each protocol
conversion action - one HasScope flag and the other without it.

  Removes more static sites.

Tomas
04de57c72c08025a49b7ee04260163f2?d=identicon&s=25 Martin Maly (Guest)
on 2008-12-10 03:23
(Received via mailing list)
DLR looks good
F983f0c990cba2fe743ef62a975ec99c?d=identicon&s=25 Curt Hagenlocher (Guest)
on 2008-12-10 04:14
(Received via mailing list)
Ruby changes look good.
This topic is locked and can not be replied to.