Forum: IronRuby Code Review: VisibilityAndOtherFixes2

Announcement (2017-05-07): www.ruby-forum.com is now read-only since I unfortunately do not have the time to support and maintain the forum any more. Please see rubyonrails.org/community and ruby-lang.org/en/community for other Rails- und Ruby-related community platforms.
Cb51033949ffccd982ae32c9f890f25a?d=identicon&s=25 Tomas Matousek (Guest)
on 2008-11-16 22:11
(Received via mailing list)
Attachment: VisibilityAndOtherFixes2.diff (300 KB)
tfpt review "/shelveset:VisibilityAndOtherFixes2;REDMOND\tomat"
  Comment  :
  Implements
      - private method visibility
      - DATA constant
      - popen and duplex IO streams (will need some refactoring of
RubyIO object)

      Fixes:
      - warnings (verbosity levels, Kernel#warn)
      - Kernel#gets, print, puts (no dynamic call to IO#puts)
      - method reflection: Kernel#methods, Kernel#singleton_methods
(methods were missing in some cases)
      - $~ variable scoping (should be an inner-most non-block scope)
      - inclusion of module already included in a super class was
handled incorrectly

Tomas
68f1bd9e9a7d9d10f0278c6535f700fe?d=identicon&s=25 Michael Letterle (Guest)
on 2008-11-17 00:26
(Received via mailing list)
On Sun, Nov 16, 2008 at 4:10 PM, Tomas Matousek <
Tomas.Matousek@microsoft.com> wrote:

>  tfpt review "/shelveset:VisibilityAndOtherFixes2;REDMOND\tomat"
>  Comment  :
>  Implements
>      - private method visibility
>
>


*drools*
F983f0c990cba2fe743ef62a975ec99c?d=identicon&s=25 Curt Hagenlocher (Guest)
on 2008-11-17 19:39
(Received via mailing list)
Changes look good.
Ade8632553a9243ae05fc920f68644c1?d=identicon&s=25 Jim Deville (Guest)
on 2008-11-17 19:44
(Received via mailing list)
Test looks good.


JD

From: ironruby-core-bounces@rubyforge.org
[mailto:ironruby-core-bounces@rubyforge.org] On Behalf Of Michael
Letterle
Sent: Sunday, November 16, 2008 3:25 PM
To: ironruby-core@rubyforge.org
Cc: IronRuby External Code Reviewers
Subject: Re: [Ironruby-core] Code Review: VisibilityAndOtherFixes2


On Sun, Nov 16, 2008 at 4:10 PM, Tomas Matousek
<Tomas.Matousek@microsoft.com<mailto:Tomas.Matousek@microsoft.com>>
wrote:
 tfpt review "/shelveset:VisibilityAndOtherFixes2;REDMOND\tomat"
 Comment  :
 Implements
     - private method visibility



*drools*
This topic is locked and can not be replied to.