Forum: IronRuby Code Review: LexicalScopes2

Announcement (2017-05-07): www.ruby-forum.com is now read-only since I unfortunately do not have the time to support and maintain the forum any more. Please see rubyonrails.org/community and ruby-lang.org/en/community for other Rails- und Ruby-related community platforms.
Cb51033949ffccd982ae32c9f890f25a?d=identicon&s=25 Tomas Matousek (Guest)
on 2008-10-30 04:39
(Received via mailing list)
Attachment: LexicalScopes2.diff (40 KB)
tfpt review "/shelveset:LexicalScopes2;REDMOND\tomat"

The actual shelveset :)

  Refactors and simplifies LexicalScope and allocation of local
variables. Previously a LocalVariable instance was created per each
local variable access, which is unnecessary. Since many scopes don't
define any variables at all we allocate a variable dictionary lazily.
  We also used to fallback to dynamic variable lookup in evals in some
cases even though we could lookup statically.

Tomas
F983f0c990cba2fe743ef62a975ec99c?d=identicon&s=25 Curt Hagenlocher (Guest)
on 2008-10-30 17:52
(Received via mailing list)
Looks good.
This topic is locked and can not be replied to.