Forum: IronRuby Re: Code Review: math

Announcement (2017-05-07): www.ruby-forum.com is now read-only since I unfortunately do not have the time to support and maintain the forum any more. Please see rubyonrails.org/community and ruby-lang.org/en/community for other Rails- und Ruby-related community platforms.
Ade8632553a9243ae05fc920f68644c1?d=identicon&s=25 Jim Deville (Guest)
on 2008-10-14 23:50
(Received via mailing list)
Attachment: math.diff (30 KB)
Doh, forgot the diff.


JD

From: Jim Deville
Sent: Tuesday, October 14, 2008 2:49 PM
To: IronRuby External Code Reviewers
Cc: ironruby-core@rubyforge.org
Subject: Code Review: math

tfpt review "/shelveset:math;REDMOND\jdeville"

Comment  :
 Implements most of the missing math methods. Modifies specs around
those. Math.erf and Math.erfc are still unimplemented, and all Math
methods still don't handle nil or coersion correctly.

~~~~
JD
http://blog.jredville.com
F983f0c990cba2fe743ef62a975ec99c?d=identicon&s=25 Curt Hagenlocher (Guest)
on 2008-10-14 23:58
(Received via mailing list)
Looks good overall. You should probably resort the frexp, hypot and
ldexp methods back into alphabetical order.

From: Jim Deville
Sent: Tuesday, October 14, 2008 2:50 PM
To: Jim Deville; IronRuby External Code Reviewers
Cc: ironruby-core@rubyforge.org
Subject: RE: Code Review: math

Doh, forgot the diff.


JD

From: Jim Deville
Sent: Tuesday, October 14, 2008 2:49 PM
To: IronRuby External Code Reviewers
Cc: ironruby-core@rubyforge.org
Subject: Code Review: math

tfpt review "/shelveset:math;REDMOND\jdeville"

Comment  :
 Implements most of the missing math methods. Modifies specs around
those. Math.erf and Math.erfc are still unimplemented, and all Math
methods still don't handle nil or coersion correctly.

~~~~
JD
http://blog.jredville.com
This topic is locked and can not be replied to.