Forum: IronRuby Code Review: MoreDefaultProtocols

Announcement (2017-05-07): www.ruby-forum.com is now read-only since I unfortunately do not have the time to support and maintain the forum any more. Please see rubyonrails.org/community and ruby-lang.org/en/community for other Rails- und Ruby-related community platforms.
Cb51033949ffccd982ae32c9f890f25a?d=identicon&s=25 Tomas Matousek (Guest)
on 2008-10-07 00:43
(Received via mailing list)
Attachment: MoreDefaultProtocols.diff (70 KB)
tfpt review "/shelveset:MoreDefaultProtocols;REDMOND\tomat"

  Introduces more default protocol conversions.

Tomas
F983f0c990cba2fe743ef62a975ec99c?d=identicon&s=25 Curt Hagenlocher (Guest)
on 2008-10-07 01:40
(Received via mailing list)
Some methods that were changed from object[] to MutableString[] aren't
tagged with [DefaultProtocol].  Is this conversion enabled by default?

Why can't FileOps.UpdateTimes use the protocol conversion? Is to for
semantic compatibility? (ie don't call to_s if the time conversion
fails)

Looks good otherwise.
Cb51033949ffccd982ae32c9f890f25a?d=identicon&s=25 Tomas Matousek (Guest)
on 2008-10-07 01:41
(Received via mailing list)
The methods that take MutableString[] are not [RubyMethods] - they're
just helper methods.
We don't support [DefaultProtocol] on arrays of MutableString yet. But
this change is the first step in that direction.

UpdateTimes have two overloads - one taking a single string and the
other arbitrary number of arbitrary objects on which default protocol
conversion is applied. So as soon as [DefaultProtocol] works on params
array we can use it here.

Tomas
F983f0c990cba2fe743ef62a975ec99c?d=identicon&s=25 Curt Hagenlocher (Guest)
on 2008-10-07 01:43
(Received via mailing list)
Ah, okay.  I obviously missed that they weren't RubyMethods.
This topic is locked and can not be replied to.