Forum: Ruby convert xml to csv in ruby and write it to a text file

226b1b809a0b1b7616e539cead7ef687?d=identicon&s=25 Alfred Pier (pier)
on 2011-04-28 15:04
Hello guys ! I'm new in Ruby....Hope you can help because i'm trying a
lot and just can't see where is the problem..
I have this xml, and not only this, i want just for any xml file that i
might put :

<?xml version="1.0"?>
<records>
   <company>
     <id>p1</id>
     <name>Skoda</name>
     <price>10000</price>
     <stock>4</stock>
     <country>Czech Republic</country>
  </company>
  <company>
     <id>p2</id>
     <name>Mercedes</name>
     <price>50000</price>
     <stock>5</stock>
     <country>Germany</country>
  </company>
  <company>
     <id>p3</id>
     <name>Alfa Romeo</name>
     <price>18000</price>
     <stock>19</stock>
     <country>Italy</country>
  </company>
  <company>
     <id>p4</id>
     <name>Fiat</name>
     <price>1500</price>
     <stock>15000</stock>
     <country>Italy</country>
  </company>
</records>


AND USING THE CODE BELOW:

require 'nokogiri'
require 'pp'

xmldoc = Nokogiri::XML(IO.read("xmlinputfile.xml"))
columns = xmldoc.xpath('/*/*[position()=1]/*').map(&:name)

print "give csv output file\n"
csvoutputfile = gets.chomp
File.open(csvoutputfile, 'w') do |f|
   rows =[]
   xmldoc.xpath('/*/*').each do |row_xml|
          row_values = []
          f.puts "  #{rows << row_values}"
          row_xml.xpath('./*').each do |field|
                f.puts "#{row_values << field.text}"

          end
   end
   pp rows


 end




 I WANT TO CONVERT IT TO CSV FORMAT LIKE THIS:

id,name,price,stock,country
p1,Skoda,10000,4,Czech Republic,
p2,Mercedes,50000,5,Germany,
.
.
.
. and so on



THE RUBY CODE OF CONVERTION WORKS FINE BUT ONLY WHEN I RUN IT IN THE
COMMAND PROMT, ONLY THERE IS SHOWS THE CSV FORMAT RIGHT

BUT I WANT TO WRITE IT IN A TXT FILE AND THIS IS WHAT I GET WHEN I TRY
WRITING IT INTO A txt :


    [[]]

["p1"]
["p1", "Skoda"]
["p1", "Skoda", "10000"]
["p1", "Skoda", "10000", "4"]
["p1", "Skoda", "10000", "4", "Czech Republic"]
[["p1", "Skoda", "10000", "4", "Czech Republic"], []]
["p2"]
["p2", "Mercedes"]
["p2", "Mercedes", "50000"]
["p2", "Mercedes", "50000", "5"]
["p2", "Mercedes", "50000", "5", "Germany"]

[["p1", "Skoda", "10000", "4", "Czech Republic"], ["p2", "Mercedes",
"50000", "5", "Germany"], []]
["p3"]
["p3", "Alfa Romeo"]
["p3", "Alfa Romeo", "18000"]
["p3", "Alfa Romeo", "18000", "19"]
["p3", "Alfa Romeo", "18000", "19", "Italy"]
[["p1", "Skoda", "10000", "4", "Czech Republic"], ["p2", "Mercedes",
"50000", "5", "Germany"],
["p3", "Alfa     Romeo", "18000", "19", "Italy"],[]]



PLEASE CAN ANYBODY SHOW ME MY MISTAKE AND WHAT SHOULD I DO BECAUSE I
CANNOT FIND IT... AND I
DON'T UNDERSTAND THE REASON THAT IT SHOWS IT LIKE THIS IN THE txt FILE.

THANK YOU IN ADVANCE !!
E0d864d9677f3c1482a20152b7cac0e2?d=identicon&s=25 Robert Klemme (robert_k78)
on 2011-04-28 16:03
(Received via mailing list)
On Thu, Apr 28, 2011 at 3:04 PM, Alfred Pier
<marineforlifecobra@yahoo.gr> wrote:
>   <price>10000</price>
> <company>
>   <stock>15000</stock>
> xmldoc = Nokogiri::XML(IO.read("xmlinputfile.xml"))
> columns = xmldoc.xpath('/*/*[position()=1]/*').map(&:name)

IMHO this is sufficient as XPath: '/*/*[1]/*'

> print "give csv output file\n"
> csvoutputfile = gets.chomp
> File.open(csvoutputfile, 'w') do |f|
>  rows =[]
>  xmldoc.xpath('/*/*').each do |row_xml|
>     row_values = []
>     f.puts " #{rows << row_values}"

You should separate filling your data structure from doing CSV output
above.  Right now you are printing rows for every record!

>     row_xml.xpath('./*').each do |field|
>        f.puts "#{row_values << field.text}"

Again, you should separate filling your data structure from doing CSV
output above (or completely get rid of "rows") e.g.

puts row_xml.xpath('./*').map(&:text).join

>     end
>  end
>  pp rows

You are seeing output of that last line.

>
> end

I would also consider using CSV for writing because that will give you
proper quoting

CSV.open("foo.txt", "w", col_sep:",") do |csv|
...
  csv << row_xml.xpath('./*').map(&:text)
...
end

>
>
> THE RUBY CODE OF CONVERTION WORKS FINE BUT ONLY WHEN I RUN IT IN THE
> COMMAND PROMT, ONLY THERE IS SHOWS THE CSV FORMAT RIGHT
>
> BUT I WANT TO WRITE IT IN A TXT FILE AND THIS IS WHAT I GET WHEN I TRY
> WRITING IT INTO A txt :

Do you use output redirection for your script?

> ["p2", "Mercedes", "50000"]
> [["p1", "Skoda", "10000", "4", "Czech Republic"], ["p2", "Mercedes",
> "50000", "5", "Germany"],
> ["p3", "Alfa   Romeo", "18000", "19", "Italy"],[]]
>
>
>
> PLEASE CAN ANYBODY SHOW ME MY MISTAKE AND WHAT SHOULD I DO BECAUSE I
> CANNOT FIND IT... AND I
> DON'T UNDERSTAND THE REASON THAT IT SHOWS IT LIKE THIS IN THE txt FILE.
>
> THANK YOU IN ADVANCE !!

Please do NOT shout.

robert
Please log in before posting. Registration is free and takes only a minute.
Existing account

NEW: Do you have a Google/GoogleMail, Yahoo or Facebook account? No registration required!
Log in with Google account | Log in with Yahoo account | Log in with Facebook account
No account? Register here.